Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable parallel apply tests #7802

Merged
merged 1 commit into from
Jul 13, 2023
Merged

enable parallel apply tests #7802

merged 1 commit into from
Jul 13, 2023

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #7746

Problem Summary:

What is changed and how it works?

Enable parallel apply tests since pingcap/tidb#45299 is fixed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2023
xzhangxian1008
xzhangxian1008 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 13, 2023
@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 03:15:11.49384348 +0000 UTC m=+561003.264182192: ☑️ agreed by xzhangxian1008.
  • 2023-07-13 03:16:00.803716395 +0000 UTC m=+561052.574055108: ☑️ agreed by SeaRise.

@windtalker
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot merged commit 24acf81 into pingcap:master Jul 13, 2023
@windtalker windtalker deleted the enable_parallel_apply_test branch September 20, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @xzhangxian1008 @SeaRise