Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fetch raft log num of each region for page-ctl #7551

Merged
merged 8 commits into from
Jul 20, 2023

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented May 25, 2023

What problem does this PR solve?

Issue Number: ref #6827

Problem Summary: Support to print raft log info using page-ctl.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    run ./tiflash pagectl -V 4 --mode 6 --path /tidb-deploy/tiflash-9000/data/page/write and check the output;

it will print many lines like the following:

region id: 8867 min_raft_log_index: 241449 max_raft_log_index: 251913 log count: 10465
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2023
@lidezhu lidezhu changed the title [WIP] Support fetch raft log num of each region in UniPS [WIP] Support fetch raft log num of each region for page-ctl May 25, 2023
@JaySon-Huang
Copy link
Contributor

Can we get these changes merged into the master?

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 18, 2023

Can we get these changes merged into the master?

Yes, but there is some more function to add.

@lidezhu lidezhu changed the title [WIP] Support fetch raft log num of each region for page-ctl Support fetch raft log num of each region for page-ctl Jul 19, 2023
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Jul 19, 2023
@lidezhu lidezhu changed the title Support fetch raft log num of each region for page-ctl support fetch raft log num of each region for page-ctl Jul 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 20, 2023
@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 20, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-20 01:29:17.43248049 +0000 UTC m=+1159449.202819190: ☑️ agreed by Lloyd-Pottiger.
  • 2023-07-20 03:39:22.390979562 +0000 UTC m=+1167254.161318260: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 9711f91 into pingcap:master Jul 20, 2023
@lidezhu lidezhu deleted the improve-page-ctl0523 branch July 20, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants