Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for learner read #7549

Merged
merged 14 commits into from
May 30, 2023
Merged

Add tests for learner read #7549

merged 14 commits into from
May 30, 2023

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented May 25, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #7256

Problem Summary:

  1. Add tests for learner read and RegionRangeIndex
  2. Remove RegionMockTest from non-test utils
  3. Remove obsolete codes, and integrate similar codes

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
a
5f0080c 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • hongyunyan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@CalvinNeo
gfdgf
65cd02f 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2023
@CalvinNeo
lk
75244a0 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo CalvinNeo changed the title Support decouple of persistence of KVStore and DMCache phase 1 Add tests for learner read May 26, 2023
@CalvinNeo
ffs
feb287f 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

CalvinNeo
CalvinNeo commented May 26, 2023
View reviewed changes
dbms/src/Storages/Transaction/RegionTable.h Outdated
@@ -231,7 +231,7 @@ class RegionTable : private boost::noncopyable

FlushThresholds flush_thresholds;

Context * const context;
Context * context;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will revert this later

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2023
@CalvinNeo
Copy link
Member Author

/run-integration-test

@CalvinNeo
fix learner
cd5bef7 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-integration-test

CalvinNeo added 5 commits May 29, 2023 09:54
@CalvinNeo
fmt
37131b5 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
g
6bd4d63 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
8c8ed54 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
use region range
0f8140b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
reduce obscure key ranges
58edaaa 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2023
@CalvinNeo
r
169f6ab 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/cc @Lloyd-Pottiger @lidezhu @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested a review from JaySon-Huang May 29, 2023 15:54
@ti-chi-bot ti-chi-bot bot requested review from lidezhu and Lloyd-Pottiger May 29, 2023 15:54
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
Copy link
Member Author

/run-integration-test

Lloyd-Pottiger
Lloyd-Pottiger approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 30, 2023
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 169f6ab

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CalvinNeo
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@CalvinNeo CalvinNeo requested a review from JaySon-Huang May 30, 2023 03:48
@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: dbd9d0e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@CalvinNeo
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 0784d4c into pingcap:master May 30, 2023
CalvinNeo added a commit to CalvinNeo/tiflash that referenced this pull request Jul 3, 2023
@CalvinNeo
Add tests for learner read (pingcap#7549)
520f0df 
ref pingcap#7256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CalvinNeo @JaySon-Huang @hongyunyan @Lloyd-Pottiger