Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keep order in table scan is lost when remote read of PartitionTableScan #7529

Merged
merged 5 commits into from
May 23, 2023
Merged

fix keep order in table scan is lost when remote read of PartitionTableScan #7529

merged 5 commits into from
May 23, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented May 22, 2023 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #7519

Problem Summary:

image

2307d72c-56af-4e8d-bf4b-41f4ce19b129

keep order sometimes lost.

What is changed and how it works?

set keep order to false when remote read of PartitionTableScan

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 22, 2023
@Lloyd-Pottiger
fix
918750c 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
@Lloyd-Pottiger
refine comments
2a00cb8 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
@Lloyd-Pottiger Lloyd-Pottiger changed the title fix keep order in table scan is lost fix keep order in table scan is lost when remote read of PartitionTableScan May 23, 2023
@Lloyd-Pottiger
fix
d32f3a7 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2023
@Lloyd-Pottiger
throw exception
b693c04 
Signed-off-by: Lloyd-Pottiger <[email protected]>
JaySon-Huang
JaySon-Huang approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @SeaRise @windtalker

@ti-chi-bot ti-chi-bot bot requested review from SeaRise and windtalker May 23, 2023 09:57
windtalker
windtalker approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2023
JaySon-Huang
JaySon-Huang reviewed May 23, 2023
View reviewed changes
dbms/src/Flash/Coprocessor/TiDBTableScan.cpp
@@ -79,6 +81,7 @@ void TiDBTableScan::constructTableScanForRemoteRead(tipb::TableScan * tipb_table
for (auto id : partition_table_scan.primary_prefix_column_ids())
tipb_table_scan->add_primary_prefix_column_ids(id);
tipb_table_scan->set_is_fast_scan(partition_table_scan.is_fast_scan());
tipb_table_scan->set_keep_order(false);
Copy link
Contributor

@JaySon-Huang JaySon-Huang May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also pick this change back to release-6.5 branch @Lloyd-Pottiger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Lloyd-Pottiger
remove some log
bab4cfa 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label May 23, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: bab4cfa

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@ti-chi-bot ti-chi-bot bot merged commit efeb0c1 into pingcap:master May 23, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7535.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 23, 2023
@Lloyd-Pottiger @ti-chi-bot
fix keep order in table scan is lost when remote read of PartitionTab…
27c613e 
…leScan (pingcap#7529)

close pingcap#7519
@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7536.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 23, 2023
@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#7529
fcae41b 
Signed-off-by: ti-chi-bot <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-keep-order-lost branch May 23, 2023 13:18
ti-chi-bot bot pushed a commit that referenced this pull request May 24, 2023
@ti-chi-bot
fix keep order in table scan is lost when remote read of PartitionTab…
e63e249 
…leScan (#7529) (#7536)

close #7519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

running ch partition workload and meets error
5 participants
@Lloyd-Pottiger @ti-chi-bot @windtalker @JaySon-Huang @SeaRise