Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to new prow reviewing #7227

Merged
merged 5 commits into from
May 12, 2023
Merged

chore: migrate to new prow reviewing #7227

merged 5 commits into from
May 12, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Apr 6, 2023 •
edited
Loading

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: ref ti-community-infra/configs#824

Problem Summary:

What is changed and how it works?

Check List

Tests

  • No code

Side effects

  • None

Documentation

  • None

Release note

None

@wuhuizuo wuhuizuo marked this pull request as ready for review May 8, 2023 11:49
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot May 8, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 8, 2023
@wuhuizuo wuhuizuo added skip-issue skip-issue-check Indicates that a PR no need to check linked issue. labels May 8, 2023
zanmato1984
zanmato1984 reviewed May 12, 2023
View reviewed changes
OWNERS Show resolved Hide resolved
zanmato1984
zanmato1984 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2023
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023

@zanmato1984: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2023
@SeaRise
Copy link
Contributor

SeaRise commented May 12, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 12, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ed8fc45

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2023
@wuhuizuo wuhuizuo added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels May 12, 2023
@ti-chi-bot ti-chi-bot bot merged commit 522bea2 into master May 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #7463.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 12, 2023
@wuhuizuo @ti-chi-bot
This is an automated cherry-pick of pingcap#7227
cd2929a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #7464.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 12, 2023
@wuhuizuo @ti-chi-bot
This is an automated cherry-pick of pingcap#7227
d57c660 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2023
Merged
1 task
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #7465.

@wuhuizuo wuhuizuo deleted the feature/review-config branch May 12, 2023 10:04
ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#7227) (#7464)
1234ed4 
ref ti-community-infra/configs#824
ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#7227) (#7465)
70200bc 
ref ti-community-infra/configs#824
ti-chi-bot bot pushed a commit that referenced this pull request May 12, 2023
@ti-chi-bot
chore: migrate to new prow reviewing (#7227) (#7463)
28ccc15 
ref ti-community-infra/configs#824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuhuizuo @zanmato1984 @SeaRise @ti-chi-bot