Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same rust-toolchain for all Rust sub-projects #7200

Merged
merged 3 commits into from
Mar 31, 2023

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Mar 31, 2023

What problem does this PR solve?

Issue Number: close #7198

Problem Summary:

What is changed and how it works?

Use a symbolic link, one for all!

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. Cargo respects the rust-toolchain symbolic link override in the TiFlash root:
 ~/Work/tiflash-workspace2/libs/libsymbolization
❯ rustup toolchain list
stable-aarch64-apple-darwin
nightly-2021-04-15-aarch64-apple-darwin
nightly-2021-07-28-aarch64-apple-darwin
nightly-2022-02-14-aarch64-apple-darwin
nightly-2022-05-01-aarch64-apple-darwin
nightly-2022-06-20-aarch64-apple-darwin
nightly-2022-07-31-aarch64-apple-darwin
nightly-2022-11-15-aarch64-apple-darwin (override)
nightly-aarch64-apple-darwin (default)

 ~/Work/tiflash-workspace2/libs/libsymbolization
❯ cat ../../contrib/tiflash-proxy/rust-toolchain
───────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: ../../contrib/tiflash-proxy/rust-toolchain
───────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ nightly-2022-11-15
───────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  1. cmake triggers a recompile when tiflash-proxy/rust-toolchain is changed:
 ~/Work/tiflash-workspace2/cmake-build-debug
❯ echo "nightly-2022-07-31" > ../contrib/tiflash-proxy/rust-toolchain

 ~/Work/tiflash-workspace2/cmake-build-debug
❯ ninja tiflash
[0/2] Re-checking globbed directories...
[0/3] Building symbolization using release profile
   Compiling cc v1.0.73
   Compiling memchr v2.4.1
   Compiling autocfg v1.1.0
   Compiling libc v0.2.120
   Compiling adler v1.0.2
   Compiling gimli v0.26.1
   Compiling cfg-if v1.0.0
   Compiling lazy_static v1.4.0
   Compiling rustc-demangle v0.1.21
   Compiling miniz_oxide v0.4.4
   Compiling backtrace v0.3.64
   Compiling findshlibs v0.10.2
   Compiling addr2line v0.17.0
   Compiling object v0.27.1
   Compiling symbolization v0.0.1 (/Users/breezewish/Work/tiflash-workspace2/libs/libsymbolization)
    Finished release [optimized + debuginfo] target(s) in 3.76s
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 31, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2023
@breezewish
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 67f9456

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2023
@ti-chi-bot
Copy link
Member

@breezewish: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 7821664 into pingcap:master Mar 31, 2023
@breezewish breezewish deleted the wenxuan/sync_rust_toolchain branch April 13, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep toolchain sync for libsymbolization and tiflash-proxy
5 participants