-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expr): round decimal divide result when return type is Int512 #7035
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8fb5148
|
[2023-03-10T09:33:14.405Z] fullstack-test/mpp/left_semi_family_joins.test: OK [5.853 s] [2023-03-10T09:33:14.405Z] fullstack-test/mpp/misc_join.test: Running [2023-03-10T09:33:16.924Z] fullstack-test/mpp/misc_join.test: OK [2.457 s] [2023-03-10T09:33:16.924Z] fullstack-test/mpp/mpp_fail.test: Running [2023-03-10T09:33:22.172Z] File: fullstack-test/mpp/mpp_fail.test [2023-03-10T09:33:22.172Z] Error line: 35 [2023-03-10T09:33:22.172Z] Error: DBGInvoke get_active_threads_in_dynamic_thread_pool() [2023-03-10T09:33:22.172Z] Result: [2023-03-10T09:33:22.172Z] ┌─get_active_threads_in_dynamic_thread_pool()─┐ [2023-03-10T09:33:22.172Z] │ 1 │ [2023-03-10T09:33:22.172Z] └─────────────────────────────────────────────┘ [2023-03-10T09:33:22.172Z] Expected: [2023-03-10T09:33:22.172Z] ┌─get_active_threads_in_dynamic_thread_pool()─┐ [2023-03-10T09:33:22.172Z] │ 0 │ [2023-03-10T09:33:22.172Z] └─────────────────────────────────────────────┘ |
/run-all-tests |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
) (#7042) * This is an automated cherry-pick of #7035 Signed-off-by: ti-chi-bot <[email protected]> * Update divide.cpp * Update gtest_arithmetic_functions.cpp * Update gtest_arithmetic_functions.cpp * Update divide.cpp * Update gtest_arithmetic_functions.cpp * Merge missed fixes for decimal divide Signed-off-by: yibin <[email protected]> --------- Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: yibin <[email protected]> Co-authored-by: Zhi Qi <[email protected]> Co-authored-by: xufei <[email protected]> Co-authored-by: yibin <[email protected]>
What problem does this PR solve?
Issue Number: close #7022
Problem Summary:
part of #6471
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note