Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP].*: Refine spill agg #6997

Closed
wants to merge 21 commits into from
Closed

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 9, 2023

What problem does this PR solve?

Issue Number: ref #5900

Problem Summary:

What is changed and how it works?

  • Add Aggregator::Params::is_local_agg for fine grained agg and possible partial agg in the future.
  • Use sort base spiller for non local agg and use partition base spiller for local agg.
  • Add ExternalAggregator to refine the code of spill agg.
  • And unit test for fine grained shuffle spill agg.
  • And some other things

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2023
@SeaRise SeaRise changed the title .*: Refine spill agg [WIP] .*: Refine spill agg Mar 9, 2023
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 9, 2023
@SeaRise SeaRise changed the title [WIP] .*: Refine spill agg .*: Refine spill agg Mar 13, 2023
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 13, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 13, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/run-all-tests

@SeaRise SeaRise changed the title .*: Refine spill agg [WIP].*: Refine spill agg Mar 14, 2023
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 14, 2023
@ti-chi-bot
Copy link
Member

@SeaRise: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SeaRise SeaRise closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants