Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr):support is_ipv4 and is_ipv6 expr to tiflash #6773
feat(expr):support is_ipv4 and is_ipv6 expr to tiflash #6773
Changes from 43 commits
772c064
fae3bbf
9748c3e
359f882
9720869
b587f19
47e68f7
d2287a5
3d7a92b
e686c68
8c70e8e
380fe4d
a67c8ee
b9a499c
85ed858
4a7c64d
f14e4b7
6eb6907
cb8d9c1
b1824d4
7ce9952
33e25f6
4433ab2
f7b7954
48b3fa1
340be85
b7799ed
cea864a
127f21f
4058f1a
a20a6c6
c7f2914
f31a94a
684fef9
cc3f674
0767bd8
c0a8c52
cfc2cc2
d9802f5
88de59c
80ab34e
2bc8de1
dce17e8
fb191ff
09fd7fd
ddf1114
c23be4f
b66005f
32cef30
07e4a10
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this hold true for the case where the input is
only null
?Is there an ut to guarantee this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank u very much~
Before there was a test case where the input was all
NULL
for testingConstColumn
https://github.com/AntiTopQuark/support_ipv4_and_ipv6_func/blob/09fd7fd29c83f298ee654c9b9a416601a718b854/dbms/src/Functions/tests/gtest_is_ip_addr.cpp#L80
now I added another one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test for
DataTypeNullable<DataTypeNothing>
?You can use
in
FunctionTestUtils
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer to
gtest_strings_concat_ws.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation of
executeImpl
in ipv4 and ipv6 is similiar, and I think we can define a function to unify the logic such asThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I referenced other functions. The following template is used
Is this okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's okk