Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix RegionKVStoreTest #6768

Merged
merged 2 commits into from
Feb 8, 2023
Merged

fix RegionKVStoreTest #6768

merged 2 commits into from
Feb 8, 2023

Conversation

flowbehappy
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #6767

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2023
JaySon-Huang
JaySon-Huang reviewed Feb 7, 2023
View reviewed changes
dbms/src/Storages/Transaction/tests/kvstore_helper.h
@@ -123,9 +126,9 @@ class RegionKVStoreTest : public ::testing::Test
}
String path = TiFlashTestEnv::getContext().getPath();
auto p = path + "/metadata/";
TiFlashTestEnv::tryRemovePath(p, /*recreate=*/true);
TiFlashTestEnv::tryCreatePath(p);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we clean up the existing files that the previous run may leave?

Copy link
Contributor Author

@flowbehappy flowbehappy Feb 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we run two test cases in one process, the old logic will remove the folders(and their sub folders) generated by previous cases. Although the first-level folders are recreated, but the sub folders will not be recreated. Since the Context instance is already created, the initialization steps will not run in the second test case. It means the removed sub folders won't be created again, which causes exceptions by the following logic.
And seems not removing those folders won't cause problems.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
CalvinNeo
CalvinNeo approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@CalvinNeo
Copy link
Member

/hold for other reviewers

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@flowbehappy
Copy link
Contributor Author

/run-all-tests

@flowbehappy
Copy link
Contributor Author

/run-all-tests

@flowbehappy
Copy link
Contributor Author

/run-integration-test

@JaySon-Huang
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a455770

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot
Copy link
Member

@flowbehappy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 4f9af9d into pingcap:master Feb 8, 2023
@flowbehappy flowbehappy deleted the fix_gtest_dbms branch February 9, 2023 02:56
guo-shaoge pushed a commit to guo-shaoge/tiflash that referenced this pull request Feb 10, 2023
@flowbehappy @guo-shaoge
fix RegionKVStoreTest (pingcap#6768)
3e8ce03 
close pingcap#6767
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@flowbehappy @ywqzzy
fix RegionKVStoreTest (pingcap#6768)
2da1d65 
close pingcap#6767

Signed-off-by: ywqzzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test cast RegionKVStoreTest.KVStoreSnapshot fail
6 participants
@flowbehappy @ti-chi-bot @CalvinNeo @JaySon-Huang @ywqzzy @Lloyd-Pottiger