Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ilike function #6741

Merged
merged 32 commits into from
Feb 17, 2023
Merged

Support ilike function #6741

merged 32 commits into from
Feb 17, 2023

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Feb 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6740

Problem Summary:

What is changed and how it works?

Add ilike function which will lower the ascii characters at first and do the like operation.

benchmark:
IlikeBench/ilike/iterations:10 1011672246 ns 1009965996 ns iters:10
LikeBench/like/iterations:10 1729492677 ns 1727743975 ns iters:10

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 6, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2023
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 6, 2023
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @ywqzzy

ywqzzy
ywqzzy reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ft is necessary

@ywqzzy ywqzzy self-requested a review February 7, 2023 05:09
@xzhangxian1008
Copy link
Contributor Author

Add ft is necessary

I will add ft after tidb supports it.

solotzg
solotzg reviewed Feb 8, 2023
View reviewed changes
dbms/src/Common/StringUtils/StringUtils.h Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsStringSearch.h Outdated Show resolved Hide resolved
solotzg
solotzg reviewed Feb 8, 2023
View reviewed changes
dbms/src/Functions/FunctionsStringSearch.h Outdated
using Chars_t = ColumnString::Chars_t;
using Offsets = ColumnString::Offsets;

inline void lowerOneString(Chars_t & str_container, size_t pos, size_t size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it work for different tidb collations such as unicode ci？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it work for different tidb collations such as unicode ci？

According to pm, collation is ignored when using ilike and we only need to lower the ascii.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for ilike(ci_collation_col1, ci_collation_col2), it still only lower the ascii?

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
ywqzzy
ywqzzy reviewed Feb 16, 2023
View reviewed changes
dbms/src/Functions/FunctionsStringSearch.h Outdated
Comment on lines 47 to 52
if (isASCII(chars[i]))
{
if (isUpperAlphaASCII(chars[i]))
chars[i] = toLowerIfAlphaASCII(chars[i]);

++i;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use isUpperAlphaASCII is enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@Lloyd-Pottiger
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 244df05

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 16, 2023
@Lloyd-Pottiger
Copy link
Contributor

/hold need to fix gtest build

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@hongyunyan
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 648cd64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 17, 2023
@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2023
@ti-chi-bot ti-chi-bot merged commit 2133f4f into pingcap:master Feb 17, 2023
@xzhangxian1008 xzhangxian1008 deleted the ilike branch February 17, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@solotzg solotzg solotzg left review comments

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ilike function
7 participants
@xzhangxian1008 @ti-chi-bot @Lloyd-Pottiger @ywqzzy @hongyunyan @windtalker @solotzg