Fix an exception thrown while reading from ColumnFileTiny after add column (#6729)

[ti-chi-bot]

This is an automated cherry-pick of #6729

What problem does this PR solve?

Issue Number: close #6726

Testing workload

1. Run TPCC workload
2. Add a column
3. Only read the newly added column

This might lead to an exception with error message Reading with fields but entry size is 0

Problem Summary:

Because only the newly added column is read, fields.length() == 0. It violates an assumption in BlobStore::read and an exception is thrown

tiflash/dbms/src/Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp

Lines 62 to 80 in 4206a52

	PageStorage::PageReadFields fields;
	fields.first = data_page_id;
	for (size_t index = col_start; index < col_end; ++index)
	{
	const auto & cd = column_defines[index];
	if (auto it = colid_to_offset.find(cd.id); it != colid_to_offset.end())
	{
	auto col_index = it->second;
	fields.second.push_back(col_index);
	}
	else
	{
	// New column after ddl is not exist in this pack, fill with default value
	columns[index - col_start] = createColumnWithDefaultValue(cd, rows);
	}
	}
	auto page_map = page_reader.read({fields});
	Page page = page_map[data_page_id];

tiflash/dbms/src/Storages/Page/V3/BlobStore.cpp

Lines 582 to 586 in 4206a52

	// Read with `FieldReadInfos`, buf_size must not be 0.
	if (buf_size == 0)
	{
	throw Exception("Reading with fields but entry size is 0.", ErrorCodes::LOGICAL_ERROR);
	}

What is changed and how it works?

• In ColumnFileTiny::readFromDisk, skip reading from disk if all are filled by default column
• In BlobStore::read return an PageMap with empty Page instead of throwing exceptions
• Add some checks to ensure we will not save an empty block/empty column

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix the issue that reading the newly added column after an `ADD COLUMN` DDL might cause error

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• hongyunyan
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[lidezhu]

LGTM

[JaySon-Huang]

/run-all-tests

[hongyunyan]

LGTM

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7b9e14d