Some code refine in join

[gengliqi]

Signed-off-by: gengliqi [email protected]

What problem does this PR solve?

Issue Number: ref #5900

Problem Summary:

1. Use SavedHash for serialized to speed up the keyEquals

std::unique_ptr<ConcurrentHashMapWithSavedHash<StringRef, Mapped>> serialized;

2. fix the example

///   `select * from t1 where col1 not in (select col2 from t2 where t1.col2 > t2.col3)`
///   - other_filter is `t1.col2 > t2.col3`
///.  - other_eq_filter_from_in_column is `t1.col1 = t2.col2`

3. remove some useless code

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Lloyd-Pottiger
• windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[windtalker]

It will soonly be used when join support spill, I think we can keep it.

[gengliqi]

Why not use BlocksList blocks?

[windtalker]

Because the block in blocks is changed during insertFromBlock, the key columns are removed or moved to the start of the block.

[gengliqi]

Got it. Maybe we can change this behavior in the future. If so, we can also delete the copy of the right join key columns.

[gengliqi]

/run-all-tests

[gengliqi]

/run-all-tests

[windtalker]

LGTM

[gengliqi]

/run-all-tests

[SeaRise]

Can you fix a build fail issue in this pr?
https://cd.pingcap.net/blue/organizations/jenkins/build-common/detail/build-common/182910/pipeline

tiflash/dbms/src/DataStreams/LimitTransformAction.cpp

Line 23 in a1d8a8f

void cut(Block & block, size_t rows, size_t limit, size_t pos)

void cut(Block & block, size_t rows, size_t limit, size_t pos) ==> void cut(Block & block, size_t rows [[maybe_unused]], size_t limit, size_t pos)
:)

[gengliqi]

/merge

[ti-chi-bot]

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 7d59600

[SeaRise]

/run-integration-test