Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: rename PushDownFilter to FilterConditions #6679

Merged
merged 6 commits into from
Jan 29, 2023
Merged

*: rename PushDownFilter to FilterConditions #6679

merged 6 commits into from
Jan 29, 2023

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jan 28, 2023 •
edited
Loading

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: ref #5829

Problem Summary:

What is changed and how it works?

Since the PushDownFilter will not pushed down to tablescan, the name will be misleading and conflict with filter which is really pushed down when late materialization is enable. So, rename PushDownFilter to FilterConditions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

SeaRise
SeaRise reviewed Jan 28, 2023
View reviewed changes
dbms/src/Flash/Coprocessor/FilterConditions.h Outdated
@@ -21,15 +21,22 @@

namespace DB
{
struct PushDownFilter
struct FilterConditions;
using FilterConditionsPtr = std::shared_ptr<FilterConditions>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use shared_ptr here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overthinking, reverted.

dbms/src/Flash/Planner/plans/PhysicalMockTableScan.cpp Outdated
}

bool PhysicalMockTableScan::pushDownFilter(Context & context, const String & filter_executor_id, const tipb::Selection & selection)
bool PhysicalMockTableScan::filterConditions(Context & context, const String & filter_executor_id, const tipb::Selection & selection)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to setFilterConditions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, changed.

@Lloyd-Pottiger
address comments
111e920 
Signed-off-by: Lloyd-Pottiger <[email protected]>
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

SeaRise
SeaRise approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2023
@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

@Lloyd-Pottiger
Copy link
Contributor Author

unstable ut ComputeServerRunner.runAggTasks
https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-unit-tests/detail/tiflash-ghpr-unit-tests/7765/pipeline cc @ywqzzy

ywqzzy
ywqzzy approved these changes Jan 29, 2023
View reviewed changes
dbms/src/Flash/Coprocessor/FilterConditions.h Outdated Show resolved Hide resolved
@SeaRise SeaRise mentioned this pull request Jan 29, 2023
Closed
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 29, 2023

/lgtm

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ywqzzy ywqzzy added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 29, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Jan 29, 2023
@ywqzzy ywqzzy removed the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2023
@ywqzzy ywqzzy added the status/LGT2 Indicates that a PR has LGTM 2. label Jan 29, 2023
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Jan 29, 2023
@ywqzzy ywqzzy self-requested a review January 29, 2023 09:29
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 29, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 29, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3ee2d98

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 29, 2023
hongyunyan
hongyunyan approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

1 similar comment
@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit e64d8cc into pingcap:master Jan 29, 2023
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@Lloyd-Pottiger @ywqzzy
*: rename PushDownFilter to FilterConditions (pingcap#6679)
2d49389 
ref pingcap#5829

Signed-off-by: ywqzzy <[email protected]>
@Lloyd-Pottiger Lloyd-Pottiger deleted the rename-push-down-filter branch February 16, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongyunyan hongyunyan hongyunyan approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lloyd-Pottiger @ti-chi-bot @ywqzzy @SeaRise @hongyunyan