-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize exchange operator & Support mpp version #6596
Conversation
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
Signed-off-by: Zhigao Tong <[email protected]>
/merge |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: e5376a5
|
/hold |
/rebuild |
/run-integration-test |
/merge |
@solotzg: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-unit-test |
/run-all-tests |
/unhold |
close pingcap#6620 Signed-off-by: Zhigao Tong <[email protected]>
close pingcap#6620 Signed-off-by: Zhigao Tong <[email protected]>
close pingcap#6620 Signed-off-by: Zhigao Tong
close pingcap#6620 Signed-off-by: ywqzzy <[email protected]>
What problem does this PR solve?
Issue Number: close #6620
Problem Summary:
What is changed and how it works?
Base Modules & Utils
-march=haswell
flag for a few modulesavx2_byte_count
to optimizesize_t countBytesInFilter(const UInt8 * filt, size_t sz)
.std::chrono::steady_clock
instead ofsystem_clock
in a few modulesMpp Version Check
TiFlash will check mpp-version in
FlashService::EstablishMPPConnection
,FlashService::CancelMPPTask
,FlashService::EstablishMPPConnection
.if failed to check mpp-version is valid, tiflash will return grpc error
grpc::StatusCode::CANCELLED
with message like:Hash Partition Writer
HashPartitionWriterV1
with new codec patternHashPartitionWriterV1
supports compression mode:TunnelSenderMode::LOCAL
, must use method NONE.LZ4
.ZSTD
.NewMPPExchangeWriter
will generateHashPartitionWriterV1
when exchange type istipb::ExchangeType::Hash
and mpp-version of dag context is not 0.ExchangeReceiverBase<RPCContext>::decodeChunks
will check version ofmpp::MPPDataPacket
Grafana
Add panel
Exchange Bytes/Seconds
in GrafanaConfig
If
batch_send_min_limit_compression
LT 0, HashPartitionWriterV1 will use8192 * partition_num
.Benchmark
Notice: in the master branch, #6713 will cause performance regression, try to resolve it and get benchmark below
Check List
Tests
Side effects
Documentation
Release note