Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge output blocks if need in hash join #6529

Merged
merged 17 commits into from
Dec 27, 2022
Merged

merge output blocks if need in hash join #6529

merged 17 commits into from
Dec 27, 2022

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Dec 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #6533

Problem Summary:

What is changed and how it works?

if the output block of hash join is too small, we will save it temporarily and merge multiple return output blocks to the final output block so that the size of final block is closer to max block size.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

merge output blocks if need in hash join.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2022
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014
Copy link
Contributor Author

/run-integration-test

yibin87
yibin87 reviewed Dec 26, 2022
View reviewed changes
dbms/src/Core/Block.cpp Outdated Show resolved Hide resolved
dbms/src/Core/Block.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp Outdated Show resolved Hide resolved
@mengxin9014 mengxin9014 requested a review from yibin87 December 26, 2022 02:59
@mengxin9014
Copy link
Contributor Author

/run-all-tests

yibin87
yibin87 reviewed Dec 26, 2022
View reviewed changes
dbms/src/Core/Block.cpp Outdated Show resolved Hide resolved
dbms/src/DataStreams/HashJoinProbeBlockInputStream.cpp Outdated Show resolved Hide resolved
@mengxin9014
Copy link
Contributor Author

/run-integration-test

@mengxin9014 mengxin9014 requested a review from yibin87 December 26, 2022 04:03
yibin87
yibin87 reviewed Dec 26, 2022
View reviewed changes
dbms/src/Core/Block.cpp Outdated Show resolved Hide resolved
@mengxin9014 mengxin9014 requested a review from yibin87 December 26, 2022 04:10
yibin87
yibin87 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others lgtm.

dbms/src/Core/Block.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 26, 2022
@mengxin9014 mengxin9014 requested a review from SeaRise December 26, 2022 05:39
@mengxin9014
Copy link
Contributor Author

/run-all-tests

SeaRise
SeaRise reviewed Dec 27, 2022
View reviewed changes
dbms/src/TestUtils/ExecutorTestUtils.cpp Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/tests/gtest_segment_test_basic.cpp Show resolved Hide resolved
dbms/src/Core/Block.cpp Outdated Show resolved Hide resolved
dbms/src/DataStreams/HashJoinProbeBlockInputStream.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.cpp Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/tests/gtest_squashing_hash_join_transform.cpp Show resolved Hide resolved
@SeaRise SeaRise self-requested a review December 27, 2022 06:27
SeaRise
SeaRise approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

dbms/src/DataStreams/HashJoinProbeBlockInputStream.h Outdated Show resolved Hide resolved
dbms/src/DataStreams/SquashingHashJoinBlockTransform.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/tests/gtest_squashing_hash_join_transform.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 27, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5dac43e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 27, 2022
@mengxin9014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@mengxin9014: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74b6da0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 27, 2022
@ti-chi-bot ti-chi-bot merged commit 816b8d5 into pingcap:master Dec 27, 2022
@mengxin9014 mengxin9014 deleted the mx/mergeJoinOutBlocks branch December 27, 2022 15:37
solotzg added a commit to solotzg/tiflash that referenced this pull request Feb 1, 2023
@solotzg
revert squashing_transform in HashJoinProbeBlockInputStream
153f6f5 
----
merge output blocks if need in hash join pingcap#6529
816b8d5
----
solotzg added a commit to solotzg/tiflash that referenced this pull request Feb 2, 2023
@solotzg
revert squashing_transform in HashJoinProbeBlockInputStream
2b1e538 
----
merge output blocks if need in hash join pingcap#6529
816b8d5
----
@solotzg solotzg mentioned this pull request Feb 2, 2023
Merged
12 tasks
@windtalker windtalker mentioned this pull request Apr 11, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

merge join probe return block if need
4 participants
@mengxin9014 @ti-chi-bot @yibin87 @SeaRise