Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: Remove useless settings join_concurrent_build #6183

Merged

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Oct 25, 2022

What problem does this PR solve?

Issue Number: ref #5900

  • Remove useless settings join_concurrent_build
  • Different streams must hold different stream index, because Join.rows_not_inserted_to_map assumes that multiple streams will not operate on the same rows_not_inserted_to_map. So we should use std::max(build_pipeline.streams.size(), build_pipeline.streams_with_non_joined_data.size()) as join_build_concurrency.
    if (getFullness(kind))
    {
    for (size_t i = 0; i < getNotJoinedStreamConcurrencyInternal(); ++i)
    rows_not_inserted_to_map.push_back(std::make_unique<RowRefList>());
    }

    /// null value
    /// here ignore mutex because rows_not_inserted_to_map is privately owned by each stream thread
    for (auto index : segment_index_info[segment_index])
    {
    /// for right/full out join, need to record the rows not inserted to map
    auto * elem = reinterpret_cast<Join::RowRefList *>(pool.alloc(sizeof(Join::RowRefList)));
    insertRowToList(rows_not_inserted_to_map, elem, stored_block, index);
    }

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 25, 2022

/run-all-tests

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
@SeaRise SeaRise requested review from ywqzzy and LittleFall October 27, 2022 02:48
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: afd3fdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 27, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit a4b677e into pingcap:master Oct 27, 2022
@SeaRise SeaRise deleted the remove_settings_join_concurrent_build branch October 27, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants