Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inconsistent result before deleting some rows (#6133) #6139

Merged
merged 3 commits into from
Oct 19, 2022
Merged

fix inconsistent result before deleting some rows (#6133) #6139

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
663f681
This is an automated cherry-pick of #6133
xzhangxian1008 Oct 15, 2022
9c44602
fix
xzhangxian1008 Oct 18, 2022
625ebe4
fix
xzhangxian1008 Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions dbms/src/Functions/FunctionsLogical.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ struct NotImpl
{
using ResultType = UInt8;

static inline UInt8 apply(A a) { return !a; }
static inline bool apply(A a)
{
return !a;
}
};


Expand Down Expand Up @@ -134,7 +137,7 @@ struct AssociativeOperationImpl
AssociativeOperationImpl(UInt8ColumnPtrs & in) : vec(in[in.size() - N]->getData()), continuation(in) {}

/// Returns a combination of values in the i-th row of all columns stored in the constructor.
inline UInt8 apply(size_t i) const
inline bool apply(size_t i) const
{
if (Op::isSaturable())
{
Expand Down Expand Up @@ -176,7 +179,10 @@ struct AssociativeOperationImpl<Op, 1>

AssociativeOperationImpl(UInt8ColumnPtrs & in) : vec(in[in.size() - 1]->getData()) {}

inline UInt8 apply(size_t i) const { return vec[i]; }
inline bool apply(size_t i) const
{
return vec[i];
}
};


Expand Down