Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: refine executionSummary #6090

Merged
merged 6 commits into from
Oct 25, 2022
Merged

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Oct 10, 2022

What problem does this PR solve?

Issue Number: ref #5900

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 10, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 10, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Oct 10, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Coprocessor/DAGResponseWriter.cpp                    9                 1    88.89%           1                 0   100.00%          14                 5    64.29%           8                 1    87.50%
Coprocessor/DAGResponseWriter.h                      2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
Coprocessor/ExecutionSummary.cpp                     4                 4     0.00%           1                 1     0.00%          16                16     0.00%           2                 2     0.00%
Coprocessor/ExecutionSummary.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
Coprocessor/ExecutionSummaryCollector.cpp           61                58     4.92%           4                 3    25.00%         154               151     1.95%          58                57     1.72%
Coprocessor/ExecutionSummaryCollector.h              2                 0   100.00%           1                 0   100.00%           6                 0   100.00%           2                 0   100.00%
Coprocessor/StreamingDAGResponseWriter.cpp          45                 6    86.67%           4                 0   100.00%          99                11    88.89%          32                 4    87.50%
Coprocessor/UnaryDAGResponseWriter.cpp              28                12    57.14%           5                 0   100.00%          68                24    64.71%          20                12    40.00%
Mpp/BroadcastOrPassThroughWriter.cpp                32                 6    81.25%           4                 0   100.00%          56                13    76.79%          14                 4    71.43%
Mpp/FineGrainedShuffleWriter.cpp                    55                 4    92.73%           5                 0   100.00%          96                 9    90.62%          30                 5    83.33%
Mpp/HashPartitionWriter.cpp                         46                 4    91.30%           5                 0   100.00%          79                 4    94.94%          24                 3    87.50%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              285                96    66.32%          33                 5    84.85%         591               234    60.41%         190                88    53.68%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18387      7480             59.32%    215366  77086        64.21%

full coverage report (for internal network access only)

@ywqzzy ywqzzy marked this pull request as ready for review October 10, 2022 06:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 10, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Oct 25, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 01a18f6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 25, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Oct 25, 2022

/rebuild

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Oct 25, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 0082b41 into pingcap:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants