Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the results of tikv and tiflash are different (#5839) #5871

Merged
merged 9 commits into from
Sep 20, 2022
Merged

fix: the results of tikv and tiflash are different (#5839) #5871

merged 9 commits into from
Sep 20, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5839

What problem does this PR solve?

Issue Number: close #5849, close pingcap/tidb#37258

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Sep 14, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 14, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xzhangxian1008
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 14, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsLogical.h                266                53    80.08%          44                 9    79.55%         374                70    81.28%         188                77    59.04%
tests/gtest_logical.cpp            68                28    58.82%           4                 0   100.00%         113                 0   100.00%          16                16     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             334                81    75.75%          48                 9    81.25%         487                70    85.63%         204                93    54.41%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18355      9782             46.71%    206281  97899        52.54%

full coverage report (for internal network access only)

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 15, 2022
@xzhangxian1008
Copy link
Contributor

/run-integration-test

1 similar comment
@xzhangxian1008
Copy link
Contributor

/run-integration-test

windtalker
windtalker approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2022
SeaRise
SeaRise approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot
Copy link
Member Author

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 20, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Sep 20, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5b33662

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 20, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 20, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsLogical.h                266                53    80.08%          44                 9    79.55%         374                70    81.28%         188                77    59.04%
tests/gtest_logical.cpp            68                28    58.82%           4                 0   100.00%         113                 0   100.00%          16                16     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             334                81    75.75%          48                 9    81.25%         487                70    85.63%         204                93    54.41%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18355      9782             46.71%    206281  97901        52.54%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Sep 20, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionsLogical.h                266                53    80.08%          44                 9    79.55%         374                70    81.28%         188                77    59.04%
tests/gtest_logical.cpp            68                28    58.82%           4                 0   100.00%         113                 0   100.00%          16                16     0.00%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             334                81    75.75%          48                 9    81.25%         487                70    85.63%         204                93    54.41%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18355      9782             46.71%    206281  97883        52.55%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit b9e1871 into pingcap:release-6.1 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker windtalker approved these changes

Assignees

@xzhangxian1008 xzhangxian1008

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @xzhangxian1008 @sre-bot @SeaRise @windtalker @VelocityLight