Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump grpc to 1.44.0 #5741

Merged
merged 11 commits into from
Sep 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contrib/abseil-cpp-cmake/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
set(ABSL_ROOT_DIR "${TiFlash_SOURCE_DIR}/contrib/abseil-cpp")
set(ABSL_ROOT_DIR "${ABSL_ROOT_DIR}" PARENT_SCOPE)
if(NOT EXISTS "${ABSL_ROOT_DIR}/CMakeLists.txt")
message(FATAL_ERROR " submodule third_party/abseil-cpp is missing. To fix try run: \n git submodule update --init --recursive")
endif()
Expand Down
2 changes: 1 addition & 1 deletion contrib/grpc
Submodule grpc updated 8578 files
2 changes: 1 addition & 1 deletion contrib/protobuf
Submodule protobuf updated 1873 files
10 changes: 8 additions & 2 deletions contrib/protobuf-cmake/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,24 @@ include_directories(
set(libprotobuf_lite_files
${protobuf_source_dir}/src/google/protobuf/any_lite.cc
${protobuf_source_dir}/src/google/protobuf/arena.cc
${protobuf_source_dir}/src/google/protobuf/arenastring.cc
${protobuf_source_dir}/src/google/protobuf/extension_set.cc
${protobuf_source_dir}/src/google/protobuf/generated_enum_util.cc
${protobuf_source_dir}/src/google/protobuf/generated_message_bases.cc
${protobuf_source_dir}/src/google/protobuf/generated_message_table_driven_lite.cc
${protobuf_source_dir}/src/google/protobuf/generated_message_util.cc
${protobuf_source_dir}/src/google/protobuf/implicit_weak_message.cc
${protobuf_source_dir}/src/google/protobuf/io/coded_stream.cc
${protobuf_source_dir}/src/google/protobuf/io/io_win32.cc
${protobuf_source_dir}/src/google/protobuf/io/strtod.cc
${protobuf_source_dir}/src/google/protobuf/io/zero_copy_stream.cc
${protobuf_source_dir}/src/google/protobuf/io/zero_copy_stream_impl.cc
${protobuf_source_dir}/src/google/protobuf/io/zero_copy_stream_impl_lite.cc
${protobuf_source_dir}/src/google/protobuf/map.cc
${protobuf_source_dir}/src/google/protobuf/message_lite.cc
${protobuf_source_dir}/src/google/protobuf/parse_context.cc
${protobuf_source_dir}/src/google/protobuf/repeated_field.cc
${protobuf_source_dir}/src/google/protobuf/repeated_ptr_field.cc
${protobuf_source_dir}/src/google/protobuf/stubs/bytestream.cc
${protobuf_source_dir}/src/google/protobuf/stubs/common.cc
${protobuf_source_dir}/src/google/protobuf/stubs/int128.cc
Expand Down Expand Up @@ -68,14 +74,12 @@ set(libprotobuf_files
${protobuf_source_dir}/src/google/protobuf/io/gzip_stream.cc
${protobuf_source_dir}/src/google/protobuf/io/printer.cc
${protobuf_source_dir}/src/google/protobuf/io/tokenizer.cc
${protobuf_source_dir}/src/google/protobuf/io/zero_copy_stream_impl.cc
${protobuf_source_dir}/src/google/protobuf/map_field.cc
${protobuf_source_dir}/src/google/protobuf/message.cc
${protobuf_source_dir}/src/google/protobuf/reflection_ops.cc
${protobuf_source_dir}/src/google/protobuf/service.cc
${protobuf_source_dir}/src/google/protobuf/source_context.pb.cc
${protobuf_source_dir}/src/google/protobuf/struct.pb.cc
${protobuf_source_dir}/src/google/protobuf/stubs/mathlimits.cc
${protobuf_source_dir}/src/google/protobuf/stubs/substitute.cc
${protobuf_source_dir}/src/google/protobuf/text_format.cc
${protobuf_source_dir}/src/google/protobuf/timestamp.pb.cc
Expand Down Expand Up @@ -133,6 +137,7 @@ set(libprotoc_files
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_message.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_message_field.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_padding_optimizer.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_parse_function_generator.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_primitive_field.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_service.cc
${protobuf_source_dir}/src/google/protobuf/compiler/cpp/cpp_string_field.cc
Expand Down Expand Up @@ -165,6 +170,7 @@ set(libprotoc_files
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_generator.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_generator_factory.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_helpers.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_kotlin_generator.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_map_field.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_map_field_lite.cc
${protobuf_source_dir}/src/google/protobuf/compiler/java/java_message.cc
Expand Down
3 changes: 1 addition & 2 deletions dbms/src/Server/MockComputeClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@
#include <fmt/core.h>
#include <grpc++/grpc++.h>
#include <kvproto/tikvpb.grpc.pb.h>
using grpc::Channel;
using grpc::Status;
using grpc_impl::Channel;

namespace DB
{

/// Send RPC Requests to FlashService
/// TODO: Support more methods that FlashService serve.
/// TODO: Support more config of RPC client.
Expand Down
14 changes: 0 additions & 14 deletions dbms/src/Storages/Transaction/tests/gtest_kvstore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1494,20 +1494,6 @@ TEST_F(RegionKVStoreTest, Basic)
{
test_mergeresult();
}
{
Copy link
Contributor Author

@lidezhu lidezhu Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed because AdminResponse is a deprecated field and make test build failed.

raft_cmdpb::AdminResponse response;
response.mutable_split()->mutable_left()->add_peers()->set_id(123);
RegionState region_state;
region_state.getMutRegion().add_peers()->set_id(456);
try
{
CheckRegionForMergeCmd(response, region_state);
}
catch (Exception & e)
{
ASSERT_EQ(e.message(), "CheckRegionForMergeCmd: current region meta: peers { id: 456 }, expect: peers { id: 123 }");
}
}
}

} // namespace tests
Expand Down
2 changes: 1 addition & 1 deletion dbms/src/TestUtils/mockExecutor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ std::shared_ptr<tipb::DAGRequest> DAGRequestBuilder::build(MockDAGRequestContext
mutable_executor->clear_executor_id();
return true;
});
dag_request_ptr->release_root_executor();
std::ignore = dag_request_ptr->release_root_executor();
}

return dag_request_ptr;
Expand Down
13 changes: 11 additions & 2 deletions format-diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,19 @@ def main():

if args.check_formatted:
diff_res = run_cmd('git diff --name-only')
if diff_res:
files_not_in_contrib = [f for f in diff_res if not f.startswith('contrib')]
files_contrib = [f for f in diff_res if f.startswith('contrib')]
if files_not_in_contrib:
print('')
print('Error: found files NOT formatted')
print(''.join(diff_res))
print(''.join(files_not_in_contrib))
exit(-1)
elif files_contrib:
print('')
print('Warn: found contrib changed')
print(''.join(files_contrib))
print('')
print(''.join(run_cmd('git status')))
Comment on lines +99 to +104
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I workaround it by changing the python script

But we do need to update the files cache in CI after getting this PR merged:
https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/11258/pipeline/176

[2022-08-31T10:22:16.877Z] ++ git merge-base origin/master HEAD
[2022-08-31T10:22:16.877Z] + python3 /home/jenkins/agent/workspace/tiflash-build-common/tiflash/format-diff.py --dump_diff_files_to /tmp/tiflash-diff-files.json --repo_path /home/jenkins/agent/workspace/tiflash-build-common/tiflash --check_formatted --diff_from 79b36c3bf30dc2604b66971a54616512617e9676
[2022-08-31T10:22:19.430Z] dump 1 modified files info to /tmp/tiflash-diff-files.json
[2022-08-31T10:22:19.430Z] Files to format:
[2022-08-31T10:22:19.430Z]   /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Server/MockComputeClient.h
[2022-08-31T10:22:19.430Z] 
[2022-08-31T10:22:19.430Z] Warn: found contrib changed
[2022-08-31T10:22:19.430Z] contrib/grpc
[2022-08-31T10:22:19.430Z] 
[2022-08-31T10:22:19.430Z] 
[2022-08-31T10:22:19.430Z] # HEAD detached at e748732
[2022-08-31T10:22:19.430Z] # Changes not staged for commit:
[2022-08-31T10:22:19.430Z] #   (use "git add <file>..." to update what will be committed)
[2022-08-31T10:22:19.430Z] #   (use "git checkout -- <file>..." to discard changes in working directory)
[2022-08-31T10:22:19.430Z] #   (commit or discard the untracked or modified content in submodules)
[2022-08-31T10:22:19.430Z] #
[2022-08-31T10:22:19.430Z] #       modified:   contrib/grpc (modified content, untracked content)
[2022-08-31T10:22:19.430Z] #
[2022-08-31T10:22:19.430Z] # Untracked files:
[2022-08-31T10:22:19.430Z] #   (use "git add <file>..." to include in what will be committed)
[2022-08-31T10:22:19.430Z] #
[2022-08-31T10:22:19.430Z] #       contrib/ssl/
[2022-08-31T10:22:19.430Z] no changes added to commit (use "git add" and/or "git commit -a")
[2022-08-31T10:22:19.430Z]

else:
print("Format check passed")
else:
Expand Down