Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UT for list struct based executors #5734

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Add UT for list struct based executors #5734

merged 5 commits into from
Sep 1, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Aug 30, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5534

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 30, 2022

/run-unit-test

@ywqzzy ywqzzy self-requested a review August 30, 2022 10:08
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 30, 2022

/run-unit-test

ywqzzy
ywqzzy reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM

dbms/src/TestUtils/tests/gtest_mock_executors.cpp Outdated Show resolved Hide resolved
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 30, 2022

/run-unit-test

ywqzzy
ywqzzy approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Aug 30, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_interpreter.cpp                 140                49    65.00%           8                 0   100.00%         600                 0   100.00%          28                28     0.00%
Flash/tests/gtest_planner_interpreter.cpp         210                63    70.00%          10                 0   100.00%         930                 0   100.00%          36                36     0.00%
TestUtils/executorSerializer.cpp                   80                 7    91.25%          30                 0   100.00%         401                15    96.26%          64                11    82.81%
TestUtils/executorSerializer.h                      1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                         73                 3    95.89%          45                 1    97.78%         290                24    91.72%          32                 2    93.75%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp          181                77    57.46%          12                 0   100.00%         314                 0   100.00%          44                44     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             699               203    70.96%         120                 5    95.83%        2568                45    98.25%         204               121    40.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18436      8317             54.89%    213315  85814        59.77%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 30, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_interpreter.cpp                 140                49    65.00%           8                 0   100.00%         600                 0   100.00%          28                28     0.00%
Flash/tests/gtest_planner_interpreter.cpp         210                63    70.00%          10                 0   100.00%         930                 0   100.00%          36                36     0.00%
TestUtils/executorSerializer.cpp                   80                 7    91.25%          30                 0   100.00%         401                15    96.26%          64                11    82.81%
TestUtils/executorSerializer.h                      1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         289                24    91.70%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp          181                77    57.46%          12                 0   100.00%         314                 0   100.00%          44                44     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             700               203    71.00%         119                 5    95.80%        2567                45    98.25%         206               121    41.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18435      8318             54.88%    213314  85779        59.79%

full coverage report (for internal network access only)

@SeaRise SeaRise requested a review from gengliqi September 1, 2022 02:59
gengliqi
gengliqi approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@gengliqi gengliqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2022
@ywqzzy
Copy link
Contributor

ywqzzy commented Sep 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6705b53

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Sep 1, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_interpreter.cpp                 140                49    65.00%           8                 0   100.00%         600                 0   100.00%          28                28     0.00%
Flash/tests/gtest_planner_interpreter.cpp         210                63    70.00%          10                 0   100.00%         930                 0   100.00%          36                36     0.00%
TestUtils/executorSerializer.cpp                   80                 7    91.25%          30                 0   100.00%         401                15    96.26%          64                11    82.81%
TestUtils/executorSerializer.h                      1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                         74                 3    95.95%          44                 1    97.73%         289                24    91.70%          34                 2    94.12%
TestUtils/mockExecutor.h                           14                 4    71.43%          14                 4    71.43%          32                 6    81.25%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp          181                77    57.46%          12                 0   100.00%         314                 0   100.00%          44                44     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             700               203    71.00%         119                 5    95.80%        2567                45    98.25%         206               121    41.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18538      8320             55.12%    214442  85801        59.99%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 927b52f into pingcap:master Sep 1, 2022
@SeaRise SeaRise deleted the test_for_list_base_executor branch September 1, 2022 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@gengliqi gengliqi gengliqi approved these changes

@xzhangxian1008 xzhangxian1008 Awaiting requested review from xzhangxian1008

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add UT for list struct based executors
5 participants
@SeaRise @ti-chi-bot @sre-bot @ywqzzy @gengliqi