Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception of search_log_for_key. #5733

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

JinheLin
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #5718

Problem Summary:

  1. Some logs contain RSFilter exclude rate but not contain read_tso= will cause exception when calling getReadTSOForLog.
[2022/08/30 16:20:00.370 +08:00] [DEBUG] [DMFilePackFilter.h:217] ["DMFilePackFilter:onSyncGc RSFilter exclude rate: 0.00, after_pk: 1, after_read_packs: 1, after_filter: 1, handle_ranges: {[-9223372036854775808,9223372036854775807)}, read_packs: 0, pack_count: 1"] [thread_id=75]
  1. It didn't cause an exception before Use read tso instead of threrad ID in 'DBGInvoke search_log_for_key' #5715 because all the logs contain thread_id=.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 30, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2022
@JinheLin
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Aug 30, 2022

Coverage for changed files

Filename                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Debug/dbgFuncMisc.cpp          46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18479      8324             54.95%    213804  85944        59.80%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2022
@JinheLin
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f3409e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2022
@ti-chi-bot
Copy link
Member

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 30, 2022

Coverage for changed files

Filename                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Debug/dbgFuncMisc.cpp          46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18479      8322             54.97%    213804  85895        59.83%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 30, 2022

Coverage for changed files

Filename                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Debug/dbgFuncMisc.cpp          46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                              46                46     0.00%           3                 3     0.00%          85                85     0.00%          36                36     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18475      8322             54.96%    213729  85903        59.81%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 79b36c3 into pingcap:master Aug 30, 2022
@JinheLin JinheLin deleted the fix_ci_search_log branch September 19, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants