-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fail to create three hops of ref pages (#5612) #5674
Fix fail to create three hops of ref pages (#5612) #5674
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Signed-off-by: JaySon-Huang <[email protected]>
d22a4a9
to
b458c26
Compare
/run-all-tests |
Signed-off-by: JaySon-Huang <[email protected]>
/run-all-tests |
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
Signed-off-by: JaySon-Huang <[email protected]>
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: f6f4a4c
|
Signed-off-by: JaySon-Huang <[email protected]>
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: af9dfac
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
This is an automated cherry-pick of #5612
What problem does this PR solve?
Issue Number: close #5570
Problem Summary: As described in #5570 (comment)
What is changed and how it works?
In
VersionedPageEntries::incrRefCount
andVersionedPageEntries::resolveToPageId
(with ignore_deletes=true), we ignore deletes beforever
until we find an entry.This is base on the assumption that we won't reuse the same page id before we cleanup all the ref to a page in the upper layer.
tests:
SegmentOperationTest.SegmentLogicalSplit
PageDirectoryTest.{NewRefAfterDelRandom,NewRefToExtAfterDelRandom}
Check List
Tests
Side effects
Documentation
Release note