Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment test framework (#5150) #5661

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5150

Signed-off-by: hehechen [email protected]

What problem does this PR solve?

Issue Number: close #5151

Problem Summary:

What is changed and how it works?

Introduce a Segment test framework to make it easier for developers to construct different workloads.

  1. Developers can easily construct Segment's split, merge, mergeDelta, flushCache, write, deleteRange and other operations;
  2. Supports random construction of the above operations;
  3. Supports the expansion of different workloads, such as cluster index, sequential write, full deleted pack and other scenarios.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hehechen
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 22, 2022
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2022
@hehechen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6b031ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-5150-to-release-6.1 branch from d73141d to 759df69 Compare August 22, 2022 06:15
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Aug 22, 2022

CLA assistant check
All committers have signed the CLA.

@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-5150-to-release-6.1 branch from 759df69 to b9af22c Compare August 22, 2022 06:17
Signed-off-by: hehechen <[email protected]>
@hehechen hehechen force-pushed the cherry-pick-5150-to-release-6.1 branch from b9af22c to 58318b5 Compare August 22, 2022 06:21
@hehechen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 58318b5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 22, 2022

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DMTestEnv.h                            4                 4     0.00%           1                 1     0.00%           9                 9     0.00%           2                 2     0.00%
dm_basic_include.h                   199                18    90.95%          19                 1    94.74%         326                43    86.81%         118                24    79.66%
gtest_segment.cpp                    117                64    45.30%           4                 0   100.00%          40                 0   100.00%          30                19    36.67%
gtest_segment_test_basic.cpp         416                71    82.93%          26                 2    92.31%         332                59    82.23%         160                71    55.62%
gtest_segment_test_basic.h             9                 0   100.00%           9                 0   100.00%          11                 0   100.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                745               157    78.93%          59                 4    93.22%         718               111    84.54%         310               116    62.58%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18298      9783             46.54%    205302  98053        52.24%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 22, 2022

Coverage for changed files

Filename                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DMTestEnv.h                            4                 4     0.00%           1                 1     0.00%           9                 9     0.00%           2                 2     0.00%
dm_basic_include.h                   149                15    89.93%          19                 1    94.74%         326                43    86.81%         100                15    85.00%
gtest_segment.cpp                     33                21    36.36%           4                 0   100.00%          40                 0   100.00%          12                12     0.00%
gtest_segment_test_basic.cpp         232                40    82.76%          26                 2    92.31%         332                59    82.23%          94                35    62.77%
gtest_segment_test_basic.h             9                 0   100.00%           9                 0   100.00%          11                 0   100.00%           0                 0         -
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                427                80    81.26%          59                 4    93.22%         718               111    84.54%         208                64    69.23%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18331      9787             46.61%    205572  98063        52.30%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f8dae94 into pingcap:release-6.1 Aug 22, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants