Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect execution summary of table scan #5624

Merged
merged 4 commits into from
Aug 16, 2022
Merged

fix incorrect execution summary of table scan #5624

merged 4 commits into from
Aug 16, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Aug 15, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5625

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Aug 15, 2022
@SeaRise SeaRise requested review from ywqzzy and windtalker August 15, 2022 09:37
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 15, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 15, 2022

Coverage for changed files

Filename                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PhysicalPlan.cpp                      104                18    82.69%          14                 2    85.71%         198                50    74.75%          64                19    70.31%
PhysicalPlanNode.cpp                   14                 0   100.00%           8                 0   100.00%          50                 0   100.00%           6                 1    83.33%
PhysicalPlanNode.h                      8                 2    75.00%           8                 2    75.00%           8                 2    75.00%           0                 0         -
plans/PhysicalProjection.cpp           13                 0   100.00%           6                 0   100.00%          92                 6    93.48%           6                 0   100.00%
plans/PhysicalTableScan.cpp            27                27     0.00%           8                 8     0.00%          64                64     0.00%           8                 8     0.00%
tests/gtest_physical_plan.cpp         124                70    43.55%          15                 0   100.00%         515                 1    99.81%          42                40     4.76%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 290               117    59.66%          59                12    79.66%         927               123    86.73%         126                68    46.03%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19256      9241             52.01%    218971  94025        57.06%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 16, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
windtalker
windtalker approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

dbms/src/Flash/Planner/PhysicalPlanNode.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2022
ywqzzy
ywqzzy approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 16, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Aug 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 03eac8d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 16, 2022

Coverage for changed files

Filename                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PhysicalPlan.cpp                      104                18    82.69%          14                 2    85.71%         198                50    74.75%          64                19    70.31%
PhysicalPlanNode.cpp                   14                 0   100.00%           8                 0   100.00%          50                 0   100.00%           6                 1    83.33%
PhysicalPlanNode.h                      8                 2    75.00%           8                 2    75.00%           8                 2    75.00%           0                 0         -
plans/PhysicalProjection.cpp           13                 0   100.00%           6                 0   100.00%          92                 6    93.48%           6                 0   100.00%
plans/PhysicalTableScan.cpp            27                27     0.00%           8                 8     0.00%          64                64     0.00%           8                 8     0.00%
tests/gtest_physical_plan.cpp         124                70    43.55%          15                 0   100.00%         515                 1    99.81%          42                40     4.76%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                 290               117    59.66%          59                12    79.66%         927               123    86.73%         126                68    46.03%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18374      8362             54.49%    211575  86448        59.14%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 8404e65 into pingcap:master Aug 16, 2022
@SeaRise SeaRise deleted the fix_planner_profile branch August 16, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect execution summary of table scan
5 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker @ywqzzy