Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force to disable logical split #5577

Closed

Conversation

JaySon-Huang
Copy link
Contributor

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: close #5576

Problem Summary:
If user deploys tiflash with explicit setting profiles.default.dt_enable_logical_split = 1.
After several logical split, PageStorage V3 will throw an exception for the third time logical split and make TiFlash crash.

What is changed and how it works?

Force to disable logical split in the code path

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • ensure the logical split settings will be forced set to false by checking the log
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-6.2 and removed do-not-merge/needs-triage-completed labels Aug 9, 2022
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@breezewish
Copy link
Member

Maybe we should use ref issue instead of close issue, so that the issue can be closed when the incompatibility is resolved?

@JaySon-Huang
Copy link
Contributor Author

Maybe we should use ref issue instead of close issue, so that the issue can be closed when the incompatibility is resolved?

The issue #5576 is created for incompatibility and triage whether it needs to be resolved on release-6.2. The final incompatibility issue should be resolved as closing the original issue #5570

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 9, 2022

Coverage for changed files

Filename                                                                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/DeltaMerge/DMContext.h           4                 0   100.00%           4                 0   100.00%           7                 0   100.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         4                 0   100.00%           4                 0   100.00%           7                 0   100.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19037      9209             51.63%    215877  93609        56.64%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor Author

close as the issue is resolved by #5612

@JaySon-Huang JaySon-Huang deleted the force_disable_logical_split branch August 23, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logical split is incompatible with PageStorage V3
4 participants