fix: format throw data truncated error (#5272)

[ti-chi-bot]

This is an automated cherry-pick of #5272

What problem does this PR solve?

Issue Number: close #4891

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Manual Test:

mysql> select * from test;
+------+--------------------------------------------------------------------+
| id   | value                                                              |
+------+--------------------------------------------------------------------+
|    1 | 9999999999999999999999999999999999999999999999999999999999999.9999 |
+------+--------------------------------------------------------------------+

mysql> select format(value, -3) from test;
+------------------------------------------------------------------------------------+
| format(value, -3)                                                                  |
+------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000 |
+------------------------------------------------------------------------------------+

mysql> select format(value, 0) from test;
+------------------------------------------------------------------------------------+
| format(value, 0)                                                                   |
+------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000 |
+------------------------------------------------------------------------------------+

mysql> select format(value, 3) from test;
+----------------------------------------------------------------------------------------+
| format(value, 3)                                                                       |
+----------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000.000 |
+----------------------------------------------------------------------------------------+

mysql> select format(value, 10) from test;
+----------------------------------------------------------------------------------------------+
| format(value, 10)                                                                            |
+----------------------------------------------------------------------------------------------+
| 9,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999.9999000000 |
+----------------------------------------------------------------------------------------------+

mysql> explain select format(value, 10) from test;
+---------------------------+---------+--------------+---------------+---------------------------------------+
| id                        | estRows | task         | access object | operator info                         |
+---------------------------+---------+--------------+---------------+---------------------------------------+
| TableReader_11            | 1.00    | root         |               | data:ExchangeSender_10                |
| └─ExchangeSender_10       | 1.00    | mpp[tiflash] |               | ExchangeType: PassThrough             |
|   └─Projection_4          | 1.00    | mpp[tiflash] |               | format(test.test.value, 10)->Column#4 |
|     └─TableFullScan_9     | 1.00    | mpp[tiflash] | table:test    | keep order:false, stats:pseudo        |
+---------------------------+---------+--------------+---------------+---------------------------------------+

mysql> select * from format_test;
+------+----------+
| id   | value    |
+------+----------+
|    1 | 999.9999 |
+------+----------+

mysql> select format(value, -2) from format_test;
+-------------------+
| format(value, -2) |
+-------------------+
| 1,000             |
+-------------------+

mysql> select format(value, 0) from format_test;
+------------------+
| format(value, 0) |
+------------------+
| 1,000            |
+------------------+

mysql> select format(value, 2) from format_test;
+------------------+
| format(value, 2) |
+------------------+
| 1,000.00         |
+------------------+

mysql> select format(value, 10) from format_test;
+-------------------+
| format(value, 10) |
+-------------------+
| 999.9999000000    |
+-------------------+

mysql> explain select format(value, 10) from format_test;
+---------------------------+---------+--------------+-------------------+----------------------------------------------+
| id                        | estRows | task         | access object     | operator info                                |
+---------------------------+---------+--------------+-------------------+----------------------------------------------+
| TableReader_11            | 1.00    | root         |                   | data:ExchangeSender_10                       |
| └─ExchangeSender_10       | 1.00    | mpp[tiflash] |                   | ExchangeType: PassThrough                    |
|   └─Projection_4          | 1.00    | mpp[tiflash] |                   | format(test.format_test.value, 10)->Column#4 |
|     └─TableFullScan_9     | 1.00    | mpp[tiflash] | table:format_test | keep order:false, stats:pseudo               |
+---------------------------+---------+--------------+-------------------+----------------------------------------------+

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix the issue that format throw data truncated error

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• windtalker
• ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[xzhangxian1008]

/run-all-tests

[xzhangxian1008]

/run-all-tests

[xzhangxian1008]

/build

[sre-bot]

lines: 43.5% (50301 out of 115503)
branches: 6.5% (82328 out of 1266355)

[xzhangxian1008]

/build

[xzhangxian1008]

/build

[xzhangxian1008]

/build

[xzhangxian1008]

/build

[xzhangxian1008]

/build

[xzhangxian1008]

/run-all-tests

[xzhangxian1008]

/run-all-tests

[sre-bot]

lines: 43.5% (50300 out of 115513)
branches: 6.5% (82335 out of 1266377)

[windtalker]

LGTM

[ywqzzy]

/merge

[ti-chi-bot]

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 27362a2

[sre-bot]

lines: 43.5% (50301 out of 115513)
branches: 6.5% (82339 out of 1266377)