DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166)

[ti-chi-bot]

This is an automated cherry-pick of #5166

What problem does this PR solve?

Issue Number: close #5154

Problem Summary:

What is changed and how it works?

in decodingSchemaSnapshot, we use column name instead of offset to find cluster index id of the common handle. Because in tiflash, we don't update the indexinfo of table_info except rename ddl action. Thus, the offset of tidb_table_info is not correctly in sometimes.

Besides, I add two DDL tests based on issue #5154, concerning about clustered index.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix the TiFlash crash issue that occurs after dropping a column of a table with clustered indexes under some situations.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[hongyunyan]

/rebuild

[hongyunyan]

/run-all-tests

[hongyunyan]

/run-unit-tests

[hongyunyan]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Core/Block.cpp                                                                218                79    63.76%          44                10    77.27%         383               162    57.70%         142                61    57.04%
Debug/MockTiDB.cpp                                                            154               150     2.60%          35                33     5.71%         481               463     3.74%         102               101     0.98%
Debug/dbgFuncMockRaftCommand.cpp                                               28                28     0.00%           4                 4     0.00%         183               183     0.00%          16                16     0.00%
Debug/dbgFuncMockRaftSnapshot.cpp                                             174               162     6.90%          23                15    34.78%         553               505     8.68%         118               116     1.69%
Debug/dbgFuncRegion.cpp                                                        95                95     0.00%          13                13     0.00%         253               253     0.00%          64                64     0.00%
Debug/dbgTools.cpp                                                            168               166     1.19%          24                22     8.33%         459               446     2.83%         182               182     0.00%
Storages/Transaction/DecodingStorageSchemaSnapshot.h                           33                 1    96.97%           1                 0   100.00%          63                 1    98.41%          26                 2    92.31%
Storages/Transaction/RegionBlockReader.cpp                                     82                26    68.29%           3                 0   100.00%         164                25    84.76%          60                24    60.00%
Storages/Transaction/TiDB.cpp                                                 480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
Storages/Transaction/TiDB.h                                                    20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
Storages/Transaction/TiKVRecordFormat.h                                        99                10    89.90%          37                 1    97.30%         263                18    93.16%          44                 5    88.64%
Storages/Transaction/tests/RowCodecTestUtils.h                                 76                 4    94.74%          14                 0   100.00%         168                 1    99.40%          30                 2    93.33%
Storages/Transaction/tests/gtest_decoding_storage_schema_snapshot.cpp         251                36    85.66%           3                 0   100.00%          25                 0   100.00%          72                36    50.00%
Storages/Transaction/tests/gtest_region_block_reader.cpp                      593                99    83.31%          21                 0   100.00%         256                 4    98.44%         208                87    58.17%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                        2471              1129    54.31%         283               114    59.72%        4120              2458    40.34%        1404               850    39.46%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18242      9787             46.35%    204444  98043        52.04%

full coverage report (for internal network access only)

[JaySon-Huang]

LGTM

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1fd73e4

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[sre-bot]

Coverage for changed files

Filename                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Core/Block.cpp                                                                218                79    63.76%          44                10    77.27%         383               162    57.70%         142                61    57.04%
Debug/MockTiDB.cpp                                                            154               150     2.60%          35                33     5.71%         481               463     3.74%         102               101     0.98%
Debug/dbgFuncMockRaftCommand.cpp                                               28                28     0.00%           4                 4     0.00%         183               183     0.00%          16                16     0.00%
Debug/dbgFuncMockRaftSnapshot.cpp                                             174               162     6.90%          23                15    34.78%         553               505     8.68%         118               116     1.69%
Debug/dbgFuncRegion.cpp                                                        95                95     0.00%          13                13     0.00%         253               253     0.00%          64                64     0.00%
Debug/dbgTools.cpp                                                            168               166     1.19%          24                22     8.33%         459               446     2.83%         182               182     0.00%
Storages/Transaction/DecodingStorageSchemaSnapshot.h                           33                 1    96.97%           1                 0   100.00%          63                 1    98.41%          26                 2    92.31%
Storages/Transaction/RegionBlockReader.cpp                                     82                26    68.29%           3                 0   100.00%         164                25    84.76%          60                24    60.00%
Storages/Transaction/TiDB.cpp                                                 480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
Storages/Transaction/TiDB.h                                                    20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
Storages/Transaction/TiKVRecordFormat.h                                        99                10    89.90%          37                 1    97.30%         263                18    93.16%          44                 5    88.64%
Storages/Transaction/tests/RowCodecTestUtils.h                                 76                 4    94.74%          14                 0   100.00%         168                 1    99.40%          30                 2    93.33%
Storages/Transaction/tests/gtest_decoding_storage_schema_snapshot.cpp         251                36    85.66%           3                 0   100.00%          25                 0   100.00%          72                36    50.00%
Storages/Transaction/tests/gtest_region_block_reader.cpp                      593                99    83.31%          21                 0   100.00%         256                 4    98.44%         208                87    58.17%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                        2471              1129    54.31%         283               114    59.72%        4120              2458    40.34%        1404               850    39.46%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18249      9783             46.39%    204628  98036        52.09%

full coverage report (for internal network access only)