Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageStorage: Fix entry.tag after full gc && add more debug message (#5094) #5096

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5094

What problem does this PR solve?

Issue Number: close #5093, ref #5076

Problem Summary: The entry.tag is incorrect after full gc, this will lead to more IO caused by RegionPersister::doPersist

if (page_reader)
{
auto entry = page_reader->getPageEntry(region_id);
if (entry.isValid() && entry.tag > applied_index)
return;

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 9, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Jun 9, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 17, 2022
@JaySon-Huang
Copy link
Contributor

pending for #5147 merged first

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 17, 2022
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-5094-to-release-6.1 branch from aa73e63 to c5b66bd Compare August 18, 2022 03:43
@JaySon-Huang
Copy link
Contributor

/cc @lidezhu

@ti-chi-bot ti-chi-bot requested a review from lidezhu August 18, 2022 03:46
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 18, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/DeltaMergeStore.cpp              1456               512    64.84%          67                 5    92.54%        2046               467    77.17%         842               390    53.68%
Page/PageUtil.h                              100                16    84.00%           8                 0   100.00%         147                16    89.12%          64                20    68.75%
Page/V2/tests/gtest_page_util.cpp            104                42    59.62%           3                 0   100.00%          54                 4    92.59%          26                12    53.85%
Page/V3/BlobStore.cpp                        571               153    73.20%          57                 2    96.49%        1207               264    78.13%         360               124    65.56%
Page/V3/BlobStore.h                           12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/tests/gtest_blob_store.cpp          5528              1188    78.51%          28                 1    96.43%        1235                66    94.66%        1726               853    50.58%
Page/V3/tests/gtest_page_storage.cpp        4198              1436    65.79%          52                 7    86.54%        1296               154    88.12%        1324               737    44.34%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      11969              3349    72.02%         225                17    92.44%        6035               994    83.53%        4344              2136    50.83%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18258      9781             46.43%    204905  97984        52.18%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 18, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c5b66bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 18, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/DeltaMergeStore.cpp              1457               512    64.86%          67                 5    92.54%        2051               467    77.23%         842               391    53.56%
Page/PageUtil.h                              100                16    84.00%           8                 0   100.00%         147                16    89.12%          64                20    68.75%
Page/V2/tests/gtest_page_util.cpp            104                42    59.62%           3                 0   100.00%          54                 4    92.59%          26                12    53.85%
Page/V3/BlobStore.cpp                        571               153    73.20%          57                 2    96.49%        1207               264    78.13%         360               124    65.56%
Page/V3/BlobStore.h                           12                 2    83.33%          10                 2    80.00%          50                23    54.00%           2                 0   100.00%
Page/V3/tests/gtest_blob_store.cpp          5528              1188    78.51%          28                 1    96.43%        1235                66    94.66%        1726               853    50.58%
Page/V3/tests/gtest_page_storage.cpp        4198              1436    65.79%          52                 7    86.54%        1296               154    88.12%        1324               737    44.34%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                      11970              3349    72.02%         225                17    92.44%        6040               994    83.54%        4344              2137    50.81%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18258      9781             46.43%    204910  98001        52.17%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 1f1bb69 into pingcap:release-6.1 Aug 18, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants