Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable PageStorage V3 in UT" #5022

Closed
wants to merge 1 commit into from

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented May 27, 2022

Reverts #4884

What problem does this PR solve?

Issue Number: ref #5023

What is changed and how it works?

Disable PageStorage V3 in UT.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels May 27, 2022
@hehechen hehechen requested review from JaySon-Huang and jiaqizho May 27, 2022 10:59
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2022
@jiaqizho
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/Context.cpp                                         507               324    36.09%         166                88    46.99%        1126               696    38.19%         270               206    23.70%
Server/tests/gtest_server_config.cpp                            2186               351    83.94%          10                 0   100.00%         423                 3    99.29%         676               335    50.44%
Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp        6355              1719    72.95%          45                 1    97.78%        2895                98    96.61%        2100               937    55.38%
Storages/Page/PageStorage.h                                       19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Storages/Page/V3/tests/gtest_page_storage_mix_mode.cpp          1739               459    73.61%          15                 0   100.00%         476                21    95.59%         514               262    49.03%
Storages/Transaction/tests/gtest_region_persister.cpp           1010               328    67.52%          16                 3    81.25%         384               117    69.53%         284               148    47.89%
TestUtils/TiFlashTestEnv.cpp                                      25                 4    84.00%           4                 0   100.00%          64                 9    85.94%          14                 6    57.14%
TestUtils/TiFlashTestEnv.h                                        25                 3    88.00%           6                 0   100.00%          46                 5    89.13%          16                 3    81.25%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                          11866              3189    73.12%         281                93    66.90%        5499               952    82.69%        3874              1897    51.03%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18274      9782             46.47%    204624  98135        52.04%

full coverage report (for internal network access only)

@hehechen hehechen closed this May 27, 2022
@JaySon-Huang JaySon-Huang deleted the revert-4884-pagestorage_test branch October 20, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants