Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mix_mode in dt_workload #5011

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented May 27, 2022

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: Need support mix_mode in dt workload.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2022
@lidezhu lidezhu changed the title [WIP] support mixed_mode in dt_workload support mixed_mode in dt_workload May 27, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2022
@lidezhu lidezhu changed the title support mixed_mode in dt_workload support mix_mode in dt_workload May 27, 2022
@lidezhu lidezhu requested review from JinheLin and JaySon-Huang May 27, 2022 09:28
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2022
@JinheLin
Copy link
Contributor

JinheLin commented Jun 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aded9e8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@ti-chi-bot
Copy link
Member

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lidezhu
Copy link
Contributor Author

lidezhu commented Jun 1, 2022

/run-unit-tests

@JaySon-Huang
Copy link
Contributor

[2022-06-01T02:59:19.624Z] In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/libs/libdaemon/src/tests/gtest_daemon_config.cpp:23:
[2022-06-01T02:59:19.624Z] In file included from /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/TestUtils/TiFlashTestBasic.h:26:
[2022-06-01T02:59:19.624Z] /home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/TestUtils/TiFlashTestEnv.h:91:102: error: incomplete type 'DB::PageStorageRunMode' named in nested name specifier
[2022-06-01T02:59:19.625Z]     static void initializeGlobalContext(Strings testdata_path = {}, PageStorageRunMode ps_run_mode = PageStorageRunMode::ONLY_V3);

@lidezhu needs to resolve this compile error

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jun 1, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ab85dd9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 1, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TiFlashTestEnv.cpp                 22                 3    86.36%           4                 0   100.00%          65                 9    86.15%          12                 5    58.33%
TiFlashTestEnv.h                   25                 3    88.00%           6                 0   100.00%          46                 5    89.13%          16                 3    81.25%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              47                 6    87.23%          10                 0   100.00%         111                14    87.39%          28                 8    71.43%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9779             46.51%    204997  97989        52.20%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 800715c into pingcap:master Jun 1, 2022
@lidezhu lidezhu deleted the dtworkload-support-mixed-mode branch June 1, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants