Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metrics for storage pool run mode #4881

Merged
merged 7 commits into from
May 13, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented May 12, 2022

Signed-off-by: hehechen [email protected]

What problem does this PR solve?

Issue Number: close #4870

What is changed and how it works?

Add some metrics:

  • The global PageStorageRunMode value
  • The number of storage pool running in mix mode/v2_only/v3_only
  • The number of storage pool instances (number of table inited)
  • The KVStore region persister is running under mix mode/v2_only/v3_only

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 12, 2022
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4d9b282

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              136                40    70.59%          27                 4    85.19%         387               124    67.96%          96                41    57.29%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         124                45    63.71%          13                 0   100.00%         241                74    69.29%          70                34    51.43%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            863               422    51.10%         223                94    57.85%        1821               917    49.64%         444               287    35.36%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18121      9784             46.01%    202201  97833        51.62%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              136                40    70.59%          27                 4    85.19%         387               124    67.96%          96                41    57.29%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         124                45    63.71%          13                 0   100.00%         241                74    69.29%          70                34    51.43%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            863               422    51.10%         223                94    57.85%        1821               917    49.64%         444               287    35.36%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18121      9784             46.01%    202201  97848        51.61%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              136                40    70.59%          27                 4    85.19%         387               124    67.96%          96                41    57.29%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         124                45    63.71%          13                 0   100.00%         241                74    69.29%          70                34    51.43%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            863               422    51.10%         223                94    57.85%        1821               917    49.64%         444               287    35.36%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18121      9784             46.01%    202201  97839        51.61%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              173                67    61.27%          29                 6    79.31%         437               169    61.33%         114                56    50.88%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         124                45    63.71%          13                 0   100.00%         241                74    69.29%          70                34    51.43%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            900               449    50.11%         225                96    57.33%        1871               962    48.58%         462               302    34.63%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18124      9787             46.00%    202275  97906        51.60%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              173                67    61.27%          29                 6    79.31%         437               169    61.33%         114                56    50.88%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         124                45    63.71%          13                 0   100.00%         241                74    69.29%          70                34    51.43%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            900               449    50.11%         225                96    57.33%        1871               962    48.58%         462               302    34.63%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18148      9789             46.06%    202731  98003        51.66%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/CurrentMetrics.cpp                         70                 0   100.00%           2                 0   100.00%          11                 0   100.00%           0                 0         -
Interpreters/Context.cpp                         512               333    34.96%         166                89    46.39%        1126               701    37.74%         272               209    23.16%
Storages/DeltaMerge/StoragePool.cpp              173                67    61.27%          29                 6    79.31%         437               169    61.33%         114                56    50.88%
Storages/DeltaMerge/StoragePool.h                 21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Storages/Transaction/RegionPersister.cpp         159                80    49.69%          15                 2    86.67%         297               130    56.23%          84                48    42.86%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            935               484    48.24%         227                98    56.83%        1927              1018    47.17%         476               316    33.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18150      9790             46.06%    202787  98047        51.65%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit b8e58eb into pingcap:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics for PageStorage V3 RunMode
5 participants