Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Add more FailPoints in critical code paths #4853

Closed
wants to merge 3 commits into from
Closed

[DNM] Add more FailPoints in critical code paths #4853

wants to merge 3 commits into from

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented May 10, 2022

What problem does this PR solve?

Issue Number: close #4807

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • [ x ] Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@yibin87 yibin87 requested a review from windtalker May 10, 2022 08:45
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2022
Comment on lines +101 to +106
#define APPLY_FOR_RANDOM_FAILPOINTS_ENABLED_OUTSIDE(M) \
M(random_tunnel_failpoint) \
M(random_receiver_failpoint)

Copy link
Contributor

@JaySon-Huang JaySon-Huang May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should declare these two failpoints in APPLY_FOR_FAILPOINTS, otherwise you can not get them enabled by using FailPointHelper::enableFailPoint

#define SUB_M(NAME, flags) \
if (fail_point_name == FailPoints::NAME) \
{ \
/* FIU_ONETIME -- Only fail once; the point of failure will be automatically disabled afterwards.*/ \
fiu_enable(FailPoints::NAME, 1, nullptr, flags); \
return; \
}
#define M(NAME) SUB_M(NAME, FIU_ONETIME)
APPLY_FOR_FAILPOINTS_ONCE(M)
#undef M
#define M(NAME) SUB_M(NAME, 0)
APPLY_FOR_FAILPOINTS(M)
#undef M
#undef SUB_M

Copy link
Contributor Author

@yibin87 yibin87 May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah,I planned to enable these random failpoints by fiu-run and fiu-ctl, like fiu-run -x -c 'enable_random name=random_tunnel_failpoints,probability=0.01' tiflash xxx, in big-cluster test to see if tiflash handled correctly(don't crash and no resource leak), not used by gtest.
Now, I'll add it to be used by gtest also.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 11, 2022
@yibin87
Copy link
Contributor Author

yibin87 commented May 11, 2022

Some unexpected changes merged into this PR, closed it now.

@yibin87 yibin87 closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go over main mpp task execution path and add random fail point
3 participants