-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Add more FailPoints in critical code paths #4853
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
#define APPLY_FOR_RANDOM_FAILPOINTS_ENABLED_OUTSIDE(M) \ | ||
M(random_tunnel_failpoint) \ | ||
M(random_receiver_failpoint) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should declare these two failpoints in APPLY_FOR_FAILPOINTS
, otherwise you can not get them enabled by using FailPointHelper::enableFailPoint
tiflash/dbms/src/Common/FailPoint.cpp
Lines 142 to 156 in efd4557
#define SUB_M(NAME, flags) \ | |
if (fail_point_name == FailPoints::NAME) \ | |
{ \ | |
/* FIU_ONETIME -- Only fail once; the point of failure will be automatically disabled afterwards.*/ \ | |
fiu_enable(FailPoints::NAME, 1, nullptr, flags); \ | |
return; \ | |
} | |
#define M(NAME) SUB_M(NAME, FIU_ONETIME) | |
APPLY_FOR_FAILPOINTS_ONCE(M) | |
#undef M | |
#define M(NAME) SUB_M(NAME, 0) | |
APPLY_FOR_FAILPOINTS(M) | |
#undef M | |
#undef SUB_M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,I planned to enable these random failpoints by fiu-run and fiu-ctl, like fiu-run -x -c 'enable_random name=random_tunnel_failpoints,probability=0.01' tiflash xxx, in big-cluster test to see if tiflash handled correctly(don't crash and no resource leak), not used by gtest.
Now, I'll add it to be used by gtest also.
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
Some unexpected changes merged into this PR, closed it now. |
What problem does this PR solve?
Issue Number: close #4807
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note