-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore delmark when add minmax for pk column #4746
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
39127b9
to
85b237c
Compare
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4756. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4757. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created: #4758. |
In response to a cherrypick label: new pull request created: #4759. |
In response to a cherrypick label: new pull request created: #4760. |
In response to a cherrypick label: new pull request created: #4761. |
* ignore delmark when add minmax for pk column * remove extra line * fix static analysis Co-authored-by: lidezhu <[email protected]> Co-authored-by: lidezhu <[email protected]>
…4963) * ignore delmark when add minmax for pk column (pingcap#4746) close pingcap#4747 * fix static analysis * use release-5.4 branch image for other components * fix fullstack image
close #4747 Co-authored-by: Ti Chi Robot <[email protected]>
What problem does this PR solve?
Issue Number: close #4747
Problem Summary:
If rows in a stable pack is all mark deleted, then it's minmax index for pk column is both 0.
And when
dt_enable_skippable_place
is enabled and try to place delta index on this segment, it will filter out all pack which is not in the pk range [start_key, +infinite). So the previous stable pack is ignored.But for the place delta index algorithm, it's expected that all the rows in the pk range [start_key, +infinite) is placed no matter whether it's deleted. So when we try to read this segment using the placed delta index, it reports error like "DeltaMerge return wrong result"
What is changed and how it works?
Ignore delmark when add minmax for pk column.
Check List
Tests
Side effects
Documentation
Release note