Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the url of submodule to https url #4566

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Unify the url of submodule to https url #4566

merged 1 commit into from
Apr 2, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Apr 1, 2022 •
edited
Loading

Signed-off-by: Lloyd-Pottiger [email protected]

What problem does this PR solve?

Issue Number: close #4565

Problem Summary:

What is changed and how it works?

change url of submodule to https url

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 1, 2022
@fuzhe1989 fuzhe1989 requested review from solotzg and gengliqi April 2, 2022 02:23
@fuzhe1989 fuzhe1989 requested a review from CalvinNeo April 2, 2022 02:24
fzhedu
fzhedu approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 2, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fd6d9a4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 2, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 2, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17002      9513             44.05%    191368  96364        49.64%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0529382 into pingcap:master Apr 2, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the change-url branch April 2, 2022 04:09
@lightmelodies
Copy link

It seems that the client-c submodule should be updated to tikv/client-c#89 too...

@Lloyd-Pottiger
Copy link
Contributor Author

It seems that the client-c submodule should be updated to tikv/client-c#89 too...

yes, you are right. Thanks for your advice. Be free to open an issue about it and a associated PR is warmly welcomed!

@SeaRise SeaRise mentioned this pull request Feb 21, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@SeaRise SeaRise SeaRise approved these changes

@solotzg solotzg solotzg approved these changes

@fzhedu fzhedu fzhedu approved these changes

@gengliqi gengliqi Awaiting requested review from gengliqi

@CalvinNeo CalvinNeo Awaiting requested review from CalvinNeo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify the url of submodule to https url
8 participants
@Lloyd-Pottiger @ti-chi-bot @sre-bot @lightmelodies @fzhedu @solotzg @SeaRise @ywqzzy