Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env for using the bundled protoc for building tiflash-proxy #4461

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Mar 28, 2022

What problem does this PR solve?

Issue Number: close #4460

Problem Summary:

# protoc is installed system-wide but not runnable under my own envs
>  which protoc
/usr/local/bin/protoc
>  protoc
protoc: error while loading shared libraries: libprotoc.so.3.8.0.0: cannot open shared object file: No such file or directory

# when building tiflash proxy, it can not use the protoc in `${BUILD_DIR}/protobuf-cmake/protoc`
# and get error
>  ninja tiflash_proxy
...
+ cargo build --no-default-features --features ' portable sse protobuf-codec test-engines-rocksdb cloud-aws cloud-gcp' --release
   Compiling raft-proto v0.6.0-alpha (GitHub - tikv/raft-rs: Raft distributed consensus algorithm implemented in Rust.)
   Compiling kvproto v0.0.2 (https://github.com/pingcap/kvproto.git?rev=706fcaf286c8dd07ef59349c089f53289a32ce4c#706fcaf2)
   Compiling tipb v0.0.1 (GitHub - pingcap/tipb: TiDB protobuf)
error: failed to run custom build command for `raft-proto v0.6.0-alpha (GitHub - tikv/raft-rs: Raft distributed consensus algorithm implemented in Rust.)`
Caused by:
  process didn't exit successfully: `/DATA/disk1/jaysonhuang/tics/contrib/tiflash-proxy/target/release/build/raft-proto-2d9d1f476dd22edf/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /DATA/disk1/jaysonhuang/.cargo/registry/src/github.com-1ecc6299db9ec823/protobuf-build-0.12.3/src/protobuf_impl.rs:48:71
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed
make[1]: *** [build] Error 101
make[1]: Leaving directory `/DATA/disk1/jaysonhuang/tics/contrib/tiflash-proxy'
make: *** [release] Error 2
ninja: build stopped: subcommand failed.

What is changed and how it works?

Set the env PROTOC and PROTOC_INCLUDE while building tiflash-proxy

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 28, 2022
@JaySon-Huang JaySon-Huang self-assigned this Mar 28, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2022
@JaySon-Huang JaySon-Huang requested a review from SeaRise March 28, 2022 06:17
@JaySon-Huang JaySon-Huang added the type/bugfix This PR fixes a bug. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 41f089c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984
Copy link
Contributor

What does protoc have anything to do with tiflash proxy?

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Mar 28, 2022

@zanmato1984 tiflash-proxy need protoc to compile tipb kvproto for its Rust codes

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17049      9575             43.84%    191778  96985        49.43%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5af4530 into pingcap:master Mar 28, 2022
@JaySon-Huang JaySon-Huang deleted the fix_proxy_build branch March 28, 2022 07:27
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17049      9576             43.83%    191778  97025        49.41%

full coverage report (for internal network access only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to build tiflash-proxy when protoc is installed system-wide under some cases
6 participants