Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some log to make it easier to observe data skew #4404

Merged
merged 4 commits into from
Mar 25, 2022
Merged

Add some log to make it easier to observe data skew #4404

merged 4 commits into from
Mar 25, 2022

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Mar 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4403, close #4427

Problem Summary:

What is changed and how it works?

Add some log to make it easier to observe data skew

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2022
@SeaRise SeaRise requested review from SeaRise and JaySon-Huang March 24, 2022 02:51
fuzhe1989
fuzhe1989 reviewed Mar 24, 2022
View reviewed changes
dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp Outdated
@@ -1012,6 +1012,9 @@ BlockInputStreams DeltaMergeStore::readRaw(const Context & db_context,
size_t final_num_stream = std::min(num_streams, tasks.size());
auto read_task_pool = std::make_shared<SegmentReadTaskPool>(std::move(tasks));

String req_info = "";
if (db_context.getDAGContext() != nullptr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also check if this is a mpp task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@windtalker
address comments
f6f3266 
Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-triage-completed labels Mar 24, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@windtalker: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/ExchangeSenderBlockInputStream.cpp            27                27     0.00%           1                 1     0.00%          18                18     0.00%          10                10     0.00%
DataStreams/ExchangeSenderBlockInputStream.h              13                13     0.00%           4                 4     0.00%           9                 9     0.00%           4                 4     0.00%
DataStreams/TiRemoteBlockInputStream.h                   103               103     0.00%          15                15     0.00%         149               149     0.00%          56                56     0.00%
Storages/DeltaMerge/DMSegmentThreadInputStream.h          72                 7    90.28%           6                 0   100.00%          79                 2    97.47%          32                10    68.75%
Storages/DeltaMerge/DeltaMergeStore.cpp                 1336               480    64.07%          64                 5    92.19%        1910               435    77.23%         784               379    51.66%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1551               630    59.38%          90                25    72.22%        2165               613    71.69%         886               459    48.19%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17035      9569             43.83%    191949  97045        49.44%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022
@fuzhe1989
Copy link
Contributor

/merge

@windtalker
Copy link
Contributor Author

/run-all-tests

1 similar comment
@windtalker
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/ExchangeSenderBlockInputStream.cpp            27                27     0.00%           1                 1     0.00%          18                18     0.00%          10                10     0.00%
DataStreams/ExchangeSenderBlockInputStream.h              13                13     0.00%           4                 4     0.00%           9                 9     0.00%           4                 4     0.00%
DataStreams/TiRemoteBlockInputStream.h                   115               115     0.00%          15                15     0.00%         149               149     0.00%          60                60     0.00%
Storages/DeltaMerge/DMSegmentThreadInputStream.h          72                 7    90.28%           6                 0   100.00%          79                 2    97.47%          32                10    68.75%
Storages/DeltaMerge/DeltaMergeStore.cpp                 1340               470    64.93%          64                 5    92.19%        1911               430    77.50%         788               376    52.28%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1567               632    59.67%          90                25    72.22%        2166               608    71.93%         894               460    48.55%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17046      9572             43.85%    191848  97030        49.42%

full coverage report (for internal network access only)

@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4723169

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 24, 2022

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/ExchangeSenderBlockInputStream.cpp            27                27     0.00%           1                 1     0.00%          18                18     0.00%          10                10     0.00%
DataStreams/ExchangeSenderBlockInputStream.h              13                13     0.00%           4                 4     0.00%           9                 9     0.00%           4                 4     0.00%
DataStreams/TiRemoteBlockInputStream.h                   115               115     0.00%          15                15     0.00%         149               149     0.00%          60                60     0.00%
Storages/DeltaMerge/DMSegmentThreadInputStream.h          72                 7    90.28%           6                 0   100.00%          79                 2    97.47%          32                10    68.75%
Storages/DeltaMerge/DeltaMergeStore.cpp                 1340               470    64.93%          64                 5    92.19%        1911               430    77.50%         788               376    52.28%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1567               632    59.67%          90                25    72.22%        2166               608    71.93%         894               460    48.55%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17046      9572             43.85%    191848  97050        49.41%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 928e919 into pingcap:master Mar 25, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 25, 2022
@windtalker @ti-chi-bot
This is an automated cherry-pick of pingcap#4404
bc43795 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 25, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4430.

ti-chi-bot added a commit that referenced this pull request Mar 25, 2022
@ti-chi-bot
Add some log to make it easier to observe data skew (#4404) (#4430)
f8feb5c 
ref #4403, close #4427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no easy way to observe data skew between pipelines
5 participants
@windtalker @ti-chi-bot @sre-bot @fuzhe1989 @SeaRise