*: add macro RUNTIME_CHECK and RUNTIME_ASSERT #4398

fuzhe1989 · 2022-03-23T12:21:14Z

Signed-off-by: fuzhe1989 [email protected]

What problem does this PR solve?

Issue Number: close #4352

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

Signed-off-by: fuzhe1989 <[email protected]>

ti-chi-bot · 2022-03-23T12:21:15Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JaySon-Huang
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

fuzhe1989 · 2022-03-23T12:22:38Z

dbms/src/Common/Exception.h

+    {\
+        if (unlikely(!(condition)))\
+        {\
+            LOG_FMT_FATAL((logger), "Check {} fail! " fmt_str, #condition, __VA_ARGS__);\


Found our error.log already sets flush = true.

Signed-off-by: fuzhe1989 <[email protected]>

fuzhe1989 · 2022-03-24T02:18:25Z

/run-all-tests

windtalker

LGTM

sre-bot · 2022-03-24T02:50:47Z

Coverage for changed files

Filename                                                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/Exception.h          20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                           20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17033      9568             43.83%    191927  97044        49.44%

full coverage report (for internal network access only)

SchrodingerZhu

LGTM

JaySon-Huang

lgtm

fuzhe1989 · 2022-03-24T06:19:02Z

/merge

ti-chi-bot · 2022-03-24T06:19:03Z

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: fuzhe1989 <[email protected]>

fuzhe1989 · 2022-03-24T06:20:57Z

/merge

ti-chi-bot · 2022-03-24T06:20:58Z

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-03-24T06:50:20Z

Coverage for changed files

Filename                                                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/Exception.h          20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                           20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17033      9568             43.83%    191927  97057        49.43%

full coverage report (for internal network access only)

fuzhe1989 · 2022-03-24T08:27:13Z

/merge

ti-chi-bot · 2022-03-24T08:27:13Z

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-03-24T08:27:19Z

@fuzhe1989: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

JaySon-Huang

lgtm

fuzhe1989 · 2022-03-24T08:31:17Z

/merge

ti-chi-bot · 2022-03-24T08:31:18Z

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-03-24T08:31:23Z

This pull request has been accepted and is ready to merge.

Commit hash: 592b9ad

windtalker

LGTM

sre-bot · 2022-03-24T09:18:31Z

Coverage for changed files

Filename                                                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Common/Exception.h          20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                           20                13    35.00%          17                10    41.18%          30                23    23.33%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17044      9571             43.85%    191827  97037        49.41%

full coverage report (for internal network access only)

update

6fce442

Signed-off-by: fuzhe1989 <[email protected]>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 23, 2022

fuzhe1989 requested review from SchrodingerZhu, JaySon-Huang and windtalker March 23, 2022 12:21

fuzhe1989 changed the title *: add macros RUNTIME_CHECK and RUNTIME_ASSERT *: add macro RUNTIME_CHECK and RUNTIME_ASSERT Mar 23, 2022

fuzhe1989 commented Mar 23, 2022

View reviewed changes

fuzhe1989 added 2 commits March 23, 2022 21:29

Merge branch 'master' into fuzhe/runtime_check

162a7dd

format

90a87d4

Signed-off-by: fuzhe1989 <[email protected]>

windtalker approved these changes Mar 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022

SchrodingerZhu approved these changes Mar 24, 2022

View reviewed changes

JaySon-Huang reviewed Mar 24, 2022

View reviewed changes

format

592b9ad

Signed-off-by: fuzhe1989 <[email protected]>

fuzhe1989 added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

fuzhe1989 added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 24, 2022

ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Mar 24, 2022

fuzhe1989 removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 24, 2022

JaySon-Huang approved these changes Mar 24, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2022

Merge branch 'master' into fuzhe/runtime_check

2b97279

windtalker approved these changes Mar 24, 2022

View reviewed changes

Merge branch 'master' into fuzhe/runtime_check

fbf9f62

ti-chi-bot merged commit a671d6b into pingcap:master Mar 24, 2022

fuzhe1989 deleted the fuzhe/runtime_check branch April 1, 2022 05:41

breezewish mentioned this pull request May 11, 2022

Utilize telemetry to report exceptions #4867

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: add macro RUNTIME_CHECK and RUNTIME_ASSERT #4398

*: add macro RUNTIME_CHECK and RUNTIME_ASSERT #4398

fuzhe1989 commented Mar 23, 2022

ti-chi-bot commented Mar 23, 2022 •

edited

Loading

fuzhe1989 Mar 23, 2022

fuzhe1989 commented Mar 24, 2022

windtalker left a comment

sre-bot commented Mar 24, 2022

SchrodingerZhu left a comment

JaySon-Huang left a comment

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

JaySon-Huang left a comment

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

windtalker left a comment

sre-bot commented Mar 24, 2022

*: add macro RUNTIME_CHECK and RUNTIME_ASSERT #4398

*: add macro RUNTIME_CHECK and RUNTIME_ASSERT #4398

Conversation

fuzhe1989 commented Mar 23, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 23, 2022 • edited Loading

fuzhe1989 Mar 23, 2022

Choose a reason for hiding this comment

fuzhe1989 commented Mar 24, 2022

windtalker left a comment

Choose a reason for hiding this comment

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

SchrodingerZhu left a comment

Choose a reason for hiding this comment

JaySon-Huang left a comment

Choose a reason for hiding this comment

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

JaySon-Huang left a comment

Choose a reason for hiding this comment

fuzhe1989 commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

ti-chi-bot commented Mar 24, 2022

windtalker left a comment

Choose a reason for hiding this comment

sre-bot commented Mar 24, 2022

Coverage for changed files

Coverage summary

ti-chi-bot commented Mar 23, 2022 •

edited

Loading