Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DeltaValueSpace::info thread safe #4393

Merged
merged 4 commits into from
Mar 23, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 23, 2022

What problem does this PR solve?

Issue Number: close #4376

Problem Summary: The info method on DeltaValueSpace access some non atomic variable without any synchronization.
Introduced by: #3943

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2022
@lidezhu lidezhu requested a review from flowbehappy March 23, 2022 06:21
@lidezhu lidezhu requested a review from JinheLin March 23, 2022 06:22
@lidezhu lidezhu requested a review from JaySon-Huang March 23, 2022 06:22
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 23, 2022

/run-all-tests

@lidezhu lidezhu force-pushed the fix-sanitizer0323 branch from 08489d9 to 8138c78 Compare March 23, 2022 07:20
Signed-off-by: lidezhu <[email protected]>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 23, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@JinheLin
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 55cfdf9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ColumnFilePersistedSet.cpp         252                63    75.00%          19                 0   100.00%         393                53    86.51%         200                59    70.50%
ColumnFilePersistedSet.h            13                 0   100.00%          10                 0   100.00%          23                 0   100.00%           2                 0   100.00%
MemTableSet.cpp                    119                24    79.83%           9                 0   100.00%         196                14    92.86%          96                25    73.96%
MemTableSet.h                        7                 0   100.00%           6                 0   100.00%          20                 0   100.00%           2                 0   100.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              391                87    77.75%          44                 0   100.00%         632                67    89.40%         300                84    72.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17034      9569             43.82%    191916  97033        49.44%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit f17c420 into pingcap:master Mar 23, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4396.

@lidezhu lidezhu deleted the fix-sanitizer0323 branch March 23, 2022 08:38
ti-chi-bot added a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadSanitizer reports data race in gtest_dm_delta_merge_store.cpp.
5 participants