Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log in dbms/src/client, dbms/src/common, and dbms/src/databases #4374

Merged
merged 19 commits into from
Mar 23, 2022
Merged

Improve log in dbms/src/client, dbms/src/common, and dbms/src/databases #4374

merged 19 commits into from
Mar 23, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Mar 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4346

Problem Summary:

What is changed and how it works?

Replace LOG_XXX with LOG_FMT_XXX. Detail reasion in #4346

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 22, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 22, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Client/Connection.cpp                     215               215     0.00%          31                31     0.00%         380               380     0.00%         128               128     0.00%
Common/AIO.h                               55                55     0.00%          14                14     0.00%         101               101     0.00%          28                28     0.00%
Common/Config/ConfigReloader.cpp           56                56     0.00%          11                11     0.00%          82                82     0.00%          34                34     0.00%
Common/FileChecker.cpp                     61                61     0.00%           9                 9     0.00%          95                95     0.00%          34                34     0.00%
Common/LRUCache.h                         114                67    41.23%          18                 3    83.33%         176                76    56.82%          58                40    31.03%
Common/PoolWithFailoverBase.h              89                89     0.00%          11                11     0.00%         177               177     0.00%          62                62     0.00%
Databases/test/gtest_database.cpp        2112               364    82.77%          18                 0   100.00%         630                 8    98.73%         676               344    49.11%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2702               907    66.43%         112                79    29.46%        1641               919    44.00%        1020               670    34.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17040      9576             43.80%    191885  97045        49.43%

full coverage report (for internal network access only)

@Lloyd-Pottiger
Copy link
Contributor Author

/run-integration-test

@Lloyd-Pottiger
Copy link
Contributor Author

/cc @ywqzzy

@ti-chi-bot ti-chi-bot requested a review from ywqzzy March 23, 2022 01:45
@Lloyd-Pottiger Lloyd-Pottiger self-assigned this Mar 23, 2022
ywqzzy
ywqzzy reviewed Mar 23, 2022
View reviewed changes
dbms/src/Common/LRUCache.h Outdated Show resolved Hide resolved
ywqzzy
ywqzzy reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix a little bit

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 23, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Client/Connection.cpp                     215               215     0.00%          31                31     0.00%         380               380     0.00%         128               128     0.00%
Common/AIO.h                               55                55     0.00%          14                14     0.00%         101               101     0.00%          28                28     0.00%
Common/Config/ConfigReloader.cpp           56                56     0.00%          11                11     0.00%          82                82     0.00%          34                34     0.00%
Common/FileChecker.cpp                     61                61     0.00%           9                 9     0.00%          95                95     0.00%          34                34     0.00%
Common/LRUCache.h                         114                67    41.23%          18                 3    83.33%         176                76    56.82%          58                40    31.03%
Common/PoolWithFailoverBase.h              89                89     0.00%          11                11     0.00%         177               177     0.00%          62                62     0.00%
Databases/test/gtest_database.cpp        2112               364    82.77%          18                 0   100.00%         630                 8    98.73%         676               344    49.11%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2702               907    66.43%         112                79    29.46%        1641               919    44.00%        1020               670    34.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17034      9573             43.80%    191918  97068        49.42%

full coverage report (for internal network access only)

@Lloyd-Pottiger
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@Lloyd-Pottiger: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Client/Connection.cpp                     215               215     0.00%          31                31     0.00%         380               380     0.00%         128               128     0.00%
Common/AIO.h                               55                55     0.00%          14                14     0.00%         101               101     0.00%          28                28     0.00%
Common/Config/ConfigReloader.cpp           56                56     0.00%          11                11     0.00%          82                82     0.00%          34                34     0.00%
Common/FileChecker.cpp                     61                61     0.00%           9                 9     0.00%          95                95     0.00%          34                34     0.00%
Common/LRUCache.h                         114                67    41.23%          18                 3    83.33%         176                76    56.82%          58                40    31.03%
Common/PoolWithFailoverBase.h              89                89     0.00%          11                11     0.00%         177               177     0.00%          62                62     0.00%
Databases/test/gtest_database.cpp        2112               364    82.77%          18                 0   100.00%         630                 8    98.73%         676               344    49.11%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2702               907    66.43%         112                79    29.46%        1641               919    44.00%        1020               670    34.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17034      9569             43.82%    191916  97042        49.44%

full coverage report (for internal network access only)

JaySon-Huang
JaySon-Huang approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0f55a10

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Client/Connection.cpp                     215               215     0.00%          31                31     0.00%         380               380     0.00%         128               128     0.00%
Common/AIO.h                               55                55     0.00%          14                14     0.00%         101               101     0.00%          28                28     0.00%
Common/Config/ConfigReloader.cpp           56                56     0.00%          11                11     0.00%          82                82     0.00%          34                34     0.00%
Common/FileChecker.cpp                     61                61     0.00%           9                 9     0.00%          95                95     0.00%          34                34     0.00%
Common/LRUCache.h                         114                67    41.23%          18                 3    83.33%         176                76    56.82%          58                40    31.03%
Common/PoolWithFailoverBase.h              89                89     0.00%          11                11     0.00%         177               177     0.00%          62                62     0.00%
Databases/test/gtest_database.cpp        2112               364    82.77%          18                 0   100.00%         630                 8    98.73%         676               344    49.11%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2702               907    66.43%         112                79    29.46%        1641               919    44.00%        1020               670    34.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17034      9569             43.82%    191920  97035        49.44%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

/run-integration-test

2 similar comments
@purelind
Copy link
Collaborator

/run-integration-test

@JaySon-Huang
Copy link
Contributor

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 23, 2022

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Client/Connection.cpp                     215               215     0.00%          31                31     0.00%         380               380     0.00%         128               128     0.00%
Common/AIO.h                               55                55     0.00%          14                14     0.00%         101               101     0.00%          28                28     0.00%
Common/Config/ConfigReloader.cpp           56                56     0.00%          11                11     0.00%          82                82     0.00%          34                34     0.00%
Common/FileChecker.cpp                     61                61     0.00%           9                 9     0.00%          95                95     0.00%          34                34     0.00%
Common/LRUCache.h                         114                67    41.23%          18                 3    83.33%         176                76    56.82%          58                40    31.03%
Common/PoolWithFailoverBase.h              89                89     0.00%          11                11     0.00%         177               177     0.00%          62                62     0.00%
Databases/test/gtest_database.cpp        2112               364    82.77%          18                 0   100.00%         630                 8    98.73%         676               344    49.11%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                    2702               907    66.43%         112                79    29.46%        1641               919    44.00%        1020               670    34.31%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17033      9568             43.83%    191930  97056        49.43%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d5d89c3 into pingcap:master Mar 23, 2022
@JaySon-Huang JaySon-Huang deleted the improve-client-common-databases-log branch March 23, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@Lloyd-Pottiger Lloyd-Pottiger

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Lloyd-Pottiger @ti-chi-bot @sre-bot @JaySon-Huang @purelind @ywqzzy