Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more symbolization support #4361

Merged
merged 12 commits into from
Mar 21, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Mar 21, 2022

Signed-off-by: SchrodingerZhu [email protected]

What problem does this PR solve?

Issue Number: close #4360

Problem Summary:

What is changed and how it works?

Provide more addr2line support.

Notice: _tiflash_symbolize will hold lock (due to backtrace_rs::resolve's needs to update some global cache). However, it should be rare for us to print out the stacktrace, so the performance impact can be ignored.


Updated Format

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • JinheLin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 21, 2022
@SchrodingerZhu SchrodingerZhu requested a review from JinheLin March 21, 2022 08:42
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 21, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2022
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/StackTrace.cpp                       7                 0   100.00%           3                 0   100.00%          22                 0   100.00%           2                 0   100.00%
dbms/src/Common/StackTrace.h                        17                 4    76.47%           1                 0   100.00%          49                12    75.51%          12                 3    75.00%
dbms/src/Common/tests/gtest_stacktrace.cpp          68                 3    95.59%           6                 0   100.00%          54                 0   100.00%          28                 7    75.00%
libs/libdaemon/src/BaseDaemon.cpp                  564               379    32.80%          40                20    50.00%         853               434    49.12%         368               267    27.45%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              656               386    41.16%          50                20    60.00%         978               446    54.40%         410               277    32.44%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17036      9572             43.81%    191862  97028        49.43%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022
@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ae013f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 21, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/StackTrace.cpp                       7                 0   100.00%           3                 0   100.00%          22                 0   100.00%           2                 0   100.00%
dbms/src/Common/StackTrace.h                        17                 4    76.47%           1                 0   100.00%          49                12    75.51%          12                 3    75.00%
dbms/src/Common/tests/gtest_stacktrace.cpp          68                 2    97.06%           6                 0   100.00%          54                 0   100.00%          28                 7    75.00%
libs/libdaemon/src/BaseDaemon.cpp                  564               379    32.80%          40                20    50.00%         853               434    49.12%         368               267    27.45%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              656               385    41.31%          50                20    60.00%         978               446    54.40%         410               277    32.44%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17040      9576             43.80%    191885  97036        49.43%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5c21a37 into pingcap:master Mar 21, 2022
SchrodingerZhu and others added 6 commits March 22, 2022 01:59
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Signed-off-by: SchrodingerZhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also provide addr2line for StackTrace
5 participants