fix bug of handling zero date in dayofweek and dayofyear

[windtalker]

Signed-off-by: xufei [email protected]

What problem does this PR solve?

Issue Number: close #4313

Problem Summary:
As the issue described.

What is changed and how it works?

return NULL for zero date in dayofweek and dayofyear

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fuzhe1989
• yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[windtalker]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                  290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Functions/FunctionsDateTime.cpp                  27                19    29.63%           4                 2    50.00%         101                25    75.25%          16                13    18.75%
Functions/FunctionsDateTime.h                  1093               640    41.45%         326               211    35.28%        2058              1234    40.04%         546               342    37.36%
Functions/tests/gtest_dayofweekyear.cpp         260                74    71.54%           2                 0   100.00%         149                 0   100.00%          80                42    47.50%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1670               966    42.16%         368               237    35.60%        2813              1663    40.88%         966               627    35.09%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16971      9542             43.77%    191209  96834        49.36%

full coverage report (for internal network access only)

[yibin87]

LGTM

[windtalker]

/merge

[ti-chi-bot]

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 1e1705e

[sre-bot]

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                  290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Functions/FunctionsDateTime.cpp                  27                19    29.63%           4                 2    50.00%         101                25    75.25%          16                13    18.75%
Functions/FunctionsDateTime.h                  1093               640    41.45%         326               211    35.28%        2058              1234    40.04%         546               342    37.36%
Functions/tests/gtest_dayofweekyear.cpp         260                74    71.54%           2                 0   100.00%         149                 0   100.00%          80                42    47.50%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1670               966    42.16%         368               237    35.60%        2813              1663    40.88%         966               627    35.09%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16971      9542             43.77%    191209  96833        49.36%

full coverage report (for internal network access only)