Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print table_id for table which is applying snapshot #4310

Merged
merged 8 commits into from
Mar 17, 2022
Merged

print table_id for table which is applying snapshot #4310

merged 8 commits into from
Mar 17, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4311

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@lidezhu lidezhu force-pushed the add-log-0316 branch 2 times, most recently from 0246441 to f2ff2a0 Compare March 16, 2022 14:59
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 16, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2022
lidezhu added 2 commits March 16, 2022 23:25
@lidezhu
use new log macro for some file
8ca148b 
Signed-off-by: lidezhu <[email protected]>
@lidezhu
format
21bade0 
Signed-off-by: lidezhu <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@lidezhu lidezhu removed the request for review from solotzg March 16, 2022 16:17
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 16, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 16, 2022

Coverage for changed files

Filename                                                                                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/PartitionStreams.cpp         263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                 263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16936      9510             43.85%    190908  96528        49.44%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 457e082

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot
Copy link
Member

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 17, 2022

Coverage for changed files

Filename                                                                                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/PartitionStreams.cpp         263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                 263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16971      9542             43.77%    191207  96833        49.36%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 17, 2022

Coverage for changed files

Filename                                                                                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/Transaction/PartitionStreams.cpp         263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                 263               214    18.63%          21                13    38.10%         569               391    31.28%         138               117    15.22%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16971      9542             43.77%    191207  96829        49.36%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e8c372d into pingcap:master Mar 17, 2022
@lidezhu lidezhu deleted the add-log-0316 branch March 17, 2022 03:13
CalvinNeo
CalvinNeo reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve log for the process of applying snapshot
6 participants
@lidezhu @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang @CalvinNeo