Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share PageStorage V3 inside tiflash instance #4220

Merged
merged 35 commits into from
Mar 19, 2022
Merged

share PageStorage V3 inside tiflash instance #4220

merged 35 commits into from
Mar 19, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

What is changed and how it works?

  1. Add config storage.enable_ps_v3 to enable PageStorage V3 on new node;
  2. Add GlobalStoragePool as the container for global PageStorage instance;
  3. Eliminate PageIdGenerator which is accidentally introduced by previous pr;
    Detail design: https://docs.google.com/document/d/1lgY--ffdZsD67FLYFh1Prz-k13XP-IBBvEMwaK6TGNI/edit?usp=sharing

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 10, 2022
@ti-chi-bot
Copy link
Member

@lidezhu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 10, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 14, 2022
@lidezhu lidezhu changed the title [WIP] support share page storage [WIP] Share PageStorage V3 inside TiFlash instance Mar 14, 2022
@lidezhu lidezhu changed the title [WIP] Share PageStorage V3 inside TiFlash instance [WIP] share PageStorage V3 inside tiflash instance Mar 14, 2022
@lidezhu lidezhu changed the title [WIP] share PageStorage V3 inside tiflash instance share PageStorage V3 inside tiflash instance Mar 14, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 14, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 14, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@JaySon-Huang
Copy link
Contributor

Running ./tiflash dt workload with global ps v3 : lidezhu#4

JaySon-Huang
JaySon-Huang approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2022
@lidezhu lidezhu force-pushed the support-share-page-storage branch from dae44e9 to 112ae89 Compare March 18, 2022 07:36
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 18, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 18, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17016      9573             43.74%    191574  97032        49.35%

full coverage report (for internal network access only)

@JaySon-Huang JaySon-Huang mentioned this pull request Mar 18, 2022
Closed
@JaySon-Huang
Copy link
Contributor

A bug caused by this PR: #4347
/cc @lidezhu

@ti-chi-bot
Copy link
Member

@JaySon-Huang: GitHub didn't allow me to request PR reviews from the following users: lidezhu.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

A bug caused by this PR: #4347
/cc @lidezhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuzhe1989
Copy link
Contributor

A bug caused by this PR: #4347 /cc @lidezhu

but this pr hasn't merged into master.

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 18, 2022

A bug caused by this PR: #4347 /cc @lidezhu

This is an old problem in the master branch and I fixed it in this pr: #4349

jiaqizho
jiaqizho approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 19, 2022

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f41e7f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 19, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 19, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17016      9573             43.74%    191583  97047        49.34%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5f163e6 into pingcap:master Mar 19, 2022
@lidezhu lidezhu deleted the support-share-page-storage branch March 19, 2022 04:34
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 23, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy left review comments

@jiaqizho jiaqizho jiaqizho approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @fuzhe1989 @flowbehappy @jiaqizho