Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean useless processes and scripts #4153

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Clean useless processes and scripts #4153

merged 2 commits into from
Feb 28, 2022

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Feb 28, 2022

Signed-off-by: Zhigao Tong [email protected]

What problem does this PR solve?

Issue Number: ref #4141

Problem Summary:

What is changed and how it works?

  • clean links from env.sh
  • remove gtests process from it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Zhigao Tong <[email protected]>
1
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg solotzg added the type/enhancement The issue or PR belongs to an enhancement. label Feb 28, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2022
@solotzg
Copy link
Contributor Author

solotzg commented Feb 28, 2022

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a70e68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 28, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 28, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16715      9483             43.27%    186682  95642        48.77%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e387dd7 into pingcap:master Feb 28, 2022
@solotzg solotzg deleted the fix-scripts branch February 28, 2022 08:52
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 25, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16715      9483             43.27%    186682  95655        48.76%

full coverage report (for internal network access only)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants