Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine DAGStorageInterpreter #4070

Closed
wants to merge 10 commits into from
Closed

refine DAGStorageInterpreter #4070

wants to merge 10 commits into from

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Feb 18, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4118

Waiting for #3876

Problem Summary:

What is changed and how it works?

1、fix clang-tidy warnings of DAGStorageInterpreter and replace String.operator+ by fmt::format
2、remove QueryBlock in DAGStorageInterpreter
3、change private variables LearnerReadSnapshot learner_read_snapshot, ManageableStoragePtr storage, Names required_columns, NamesAndTypes source_columns and String handle_column_name to local variables of execute.
4、handle selection_name and conditions in execute
5、add UniformRandomIntGenerator to replace rand() % 100

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 18, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 23, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 24, 2022

/run-integration-test

@SeaRise SeaRise requested a review from fuzhe1989 February 24, 2022 08:56
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2022
@fuzhe1989 fuzhe1989 requested a review from LittleFall February 24, 2022 10:33
@fuzhe1989
Copy link
Contributor

Add @LittleFall as an optional reviewer.

windtalker
windtalker reviewed Feb 28, 2022
View reviewed changes
dbms/src/Flash/Coprocessor/DAGStorageInterpreter.h
void execute(DAGPipeline & pipeline);
void execute(DAGPipeline & pipeline, const String & selection_name, const std::vector<const tipb::Expr *> & conditions);

void execute(DAGPipeline & pipeline)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not set default value of selection_name/conditions so we don't have to add this new function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that execute(pipeline, selection_name) can't be called.

@windtalker
Copy link
Contributor

What is the purpose of change 3?
remove private var LearnerReadSnapshot learner_read_snapshot, ManageableStoragePtr storage, Names required_columns, NamesAndTypes source_columns and String handle_column_name

@SeaRise
Copy link
Contributor Author

SeaRise commented Feb 28, 2022

What is the purpose of change 3? remove private var LearnerReadSnapshot learner_read_snapshot, ManageableStoragePtr storage, Names required_columns, NamesAndTypes source_columns and String handle_column_name

these private variables can be changed to local variables of execute.

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 7, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022
@ti-chi-bot
Copy link
Member

@SeaRise: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@SeaRise SeaRise closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker left review comments

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SeaRise @ti-chi-bot @fuzhe1989 @windtalker