Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix date format identifies '\n' as invalid separator (#4046) #4055

Closed
wants to merge 3 commits into from
Closed

fix date format identifies '\n' as invalid separator (#4046) #4055

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ce931a
This is an automated cherry-pick of #4046
mengxin9014 Feb 16, 2022
88acd7c
Update MyTime.cpp
mengxin9014 Jun 15, 2022
3cae097
Delete gtest_tidb_conversion.cpp
mengxin9014 Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dbms/src/Common/MyTime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ bool isValidSeperator(char c, int previous_parts)
if (isPunctuation(c))
return true;

return previous_parts == 2 && (c == ' ' || c == 'T');
// for https://github.com/pingcap/tics/issues/4036
return previous_parts == 2 && (c == 'T' || isWhitespaceASCII(c));
}

std::vector<String> parseDateFormat(String format)
Expand Down