refine `appendFinalProjectFor(Non)RootQueryBlock` in analyzer #4052

SeaRise · 2022-02-16T08:48:08Z

What problem does this PR solve?

Issue Number: ref #4118

Problem Summary:

What is changed and how it works?

1、add function genNonRootFinalProjectAliases to refine the code of appendFinalProjectForNonRootQueryBlock
2、refine appendFinalProjectForRootQueryBlock and then the code like

if (isCastRequiredForRootFinalProjection) 
    appendCastForRootFinalProjection

return genRootFinalProjectAliases

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-02-16T08:48:09Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

XuHuaiyu
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SeaRise · 2022-02-16T08:48:58Z

/run-integration-test

SeaRise · 2022-02-16T09:05:07Z

/run-integration-test

SeaRise · 2022-02-16T10:10:21Z

/run-integration-test

Signed-off-by: SeaRise <[email protected]>

SeaRise · 2022-02-17T13:30:04Z

/run-integration-test

SeaRise · 2022-02-17T13:30:38Z

/run-integration-test

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h

XuHuaiyu

LGTM

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h

Co-authored-by: Fu Zhe <[email protected]>

SeaRise · 2022-03-07T09:46:03Z

/hold

SeaRise · 2022-03-18T01:50:49Z

/hold cancel

SeaRise · 2022-03-18T06:58:12Z

/run-all-tests

sre-bot · 2022-03-18T07:16:02Z

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp         329               329     0.00%          43                43     0.00%         758               758     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             331               331     0.00%          45                45     0.00%         760               760     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16981      9548             43.77%    191311  96893        49.35%

full coverage report (for internal network access only)

SeaRise · 2022-03-21T03:47:35Z

/run-all-tests

sre-bot · 2022-03-21T04:05:13Z

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp         329               329     0.00%          43                43     0.00%         760               760     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             331               331     0.00%          45                45     0.00%         762               762     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16981      9548             43.77%    191313  96888        49.36%

full coverage report (for internal network access only)

windtalker

LGTM

SeaRise · 2022-03-21T07:09:42Z

/merge

ti-chi-bot · 2022-03-21T07:09:43Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-03-21T07:09:48Z

This pull request has been accepted and is ready to merge.

Commit hash: 057858d

sre-bot · 2022-03-21T07:31:37Z

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp         329               329     0.00%          43                43     0.00%         760               760     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             331               331     0.00%          45                45     0.00%         762               762     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17024      9577             43.74%    191724  97080        49.36%

full coverage report (for internal network access only)

sre-bot · 2022-03-21T08:04:56Z

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp         329               329     0.00%          43                43     0.00%         760               760     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             331               331     0.00%          45                45     0.00%         762               762     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17024      9577             43.74%    191724  97075        49.37%

full coverage report (for internal network access only)

sre-bot · 2022-03-21T10:10:33Z

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DAGExpressionAnalyzer.cpp         329               329     0.00%          43                43     0.00%         760               760     0.00%         254               254     0.00%
DAGExpressionAnalyzer.h             2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             331               331     0.00%          45                45     0.00%         762               762     0.00%         254               254     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17031      9576             43.77%    191839  97045        49.41%

full coverage report (for internal network access only)

udpate

7d59b25

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2022

SeaRise changed the title ~~refine appendFinalProjectFor(Non)RootQueryBlock in analyzer~~ [WIP] refine appendFinalProjectFor(Non)RootQueryBlock in analyzer Feb 16, 2022

ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022

SeaRise added 2 commits February 16, 2022 16:52

add const

8f8e697

fix

b5621fe

SeaRise changed the title ~~[WIP] refine appendFinalProjectFor(Non)RootQueryBlock in analyzer~~ refine appendFinalProjectFor(Non)RootQueryBlock in analyzer Feb 16, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2022

SeaRise requested review from windtalker and LittleFall February 16, 2022 09:29

Merge branch 'master' into refine_final_project

ee6c180

format

eb5bbd2

Signed-off-by: SeaRise <[email protected]>

Merge branch 'master' into refine_final_project

62765f3

SeaRise requested a review from fuzhe1989 February 24, 2022 03:28

XuHuaiyu reviewed Feb 25, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h Outdated Show resolved Hide resolved

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h Show resolved Hide resolved

SeaRise added 2 commits February 28, 2022 10:07

Merge branch 'master' into refine_final_project

a5a8f75

address comments

89f2118

XuHuaiyu approved these changes Feb 28, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2022

ExpressionActionsPtr & --> const ExpressionActionsPtr &

d51fd37

fuzhe1989 reviewed Feb 28, 2022

View reviewed changes

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp Outdated Show resolved Hide resolved

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp Outdated Show resolved Hide resolved

dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.h Outdated Show resolved Hide resolved

SeaRise and others added 2 commits February 28, 2022 15:53

Update dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp

9f0ad91

Co-authored-by: Fu Zhe <[email protected]>

Update dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp

55ec5e2

Co-authored-by: Fu Zhe <[email protected]>

SeaRise added 3 commits March 1, 2022 17:02

Merge branch 'master' into refine_final_project

7b1a50f

address comments

38666e6

Merge branch 'master' into refine_final_project

a883481

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2022

SeaRise added 2 commits March 7, 2022 18:23

Merge branch 'master' into refine_final_project

6c38b43

update

ad12f12

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022

Merge branch 'master' into refine_final_project

d7cf5a4

update

057858d

windtalker approved these changes Mar 21, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022

Merge branch 'master' into refine_final_project

3c1fafb

Merge branch 'master' into refine_final_project

402c005

ti-chi-bot added 2 commits March 21, 2022 16:24

Merge branch 'master' into refine_final_project

20c8494

Merge branch 'master' into refine_final_project

208a994

ti-chi-bot merged commit ef608ee into pingcap:master Mar 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refine `appendFinalProjectFor(Non)RootQueryBlock` in analyzer #4052

refine `appendFinalProjectFor(Non)RootQueryBlock` in analyzer #4052

SeaRise commented Feb 16, 2022 •

edited

Loading

ti-chi-bot commented Feb 16, 2022 •

edited

Loading

SeaRise commented Feb 16, 2022

SeaRise commented Feb 16, 2022

SeaRise commented Feb 16, 2022

SeaRise commented Feb 17, 2022

SeaRise commented Feb 17, 2022

XuHuaiyu left a comment

SeaRise commented Mar 7, 2022

SeaRise commented Mar 18, 2022

SeaRise commented Mar 18, 2022

sre-bot commented Mar 18, 2022

SeaRise commented Mar 21, 2022

sre-bot commented Mar 21, 2022

windtalker left a comment

SeaRise commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

sre-bot commented Mar 21, 2022

sre-bot commented Mar 21, 2022

sre-bot commented Mar 21, 2022

refine appendFinalProjectFor(Non)RootQueryBlock in analyzer #4052

refine appendFinalProjectFor(Non)RootQueryBlock in analyzer #4052

Conversation

SeaRise commented Feb 16, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Feb 16, 2022 • edited Loading

SeaRise commented Feb 16, 2022

SeaRise commented Feb 16, 2022

SeaRise commented Feb 16, 2022

SeaRise commented Feb 17, 2022

SeaRise commented Feb 17, 2022

XuHuaiyu left a comment

Choose a reason for hiding this comment

SeaRise commented Mar 7, 2022

SeaRise commented Mar 18, 2022

SeaRise commented Mar 18, 2022

sre-bot commented Mar 18, 2022

Coverage for changed files

Coverage summary

SeaRise commented Mar 21, 2022

sre-bot commented Mar 21, 2022

Coverage for changed files

Coverage summary

windtalker left a comment

Choose a reason for hiding this comment

SeaRise commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

ti-chi-bot commented Mar 21, 2022

sre-bot commented Mar 21, 2022

Coverage for changed files

Coverage summary

sre-bot commented Mar 21, 2022

Coverage for changed files

Coverage summary

sre-bot commented Mar 21, 2022

Coverage for changed files

Coverage summary

refine `appendFinalProjectFor(Non)RootQueryBlock` in analyzer #4052

refine `appendFinalProjectFor(Non)RootQueryBlock` in analyzer #4052

SeaRise commented Feb 16, 2022 •

edited

Loading

ti-chi-bot commented Feb 16, 2022 •

edited

Loading