Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ut for cast real as xxx #3824

Merged
merged 14 commits into from
Jan 27, 2022
Merged

Add ut for cast real as xxx #3824

merged 14 commits into from
Jan 27, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 6, 2022

What problem does this PR solve?

Issue Number: close #3554

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 6, 2022
@SeaRise SeaRise changed the title [WIP] Add ut for cast real as xxx Add ut for cast real as xxx Jan 10, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 10, 2022

/run-unit-test

@SeaRise SeaRise requested review from fuzhe1989 and dragonly January 10, 2022 07:21
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/916/cobertura/
(Coverage detail url is limited office network access)

lines: 43.8% (49973 out of 114182)
branches: 6.5% (82716 out of 1264448)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-unit-test

windtalker
windtalker approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2022
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 27, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGContext.h                     28                10    64.29%          21                 9    57.14%          59                17    71.19%           8                 3    62.50%
Functions/FunctionsTiDBConversion.h               794               424    46.60%          76                25    67.11%        1786               602    66.29%         474               317    33.12%
Functions/tests/gtest_tidb_conversion.cpp        3162               766    75.77%          29                 0   100.00%        1266                 0   100.00%         976               500    48.77%
Functions/tests/gtest_timestampdiff.cpp           818               171    79.10%           3                 0   100.00%         168                 0   100.00%         240               123    48.75%
TestUtils/FunctionTestUtils.cpp                    56                 8    85.71%           8                 0   100.00%          69                 8    88.41%          24                 8    66.67%
TestUtils/FunctionTestUtils.h                      76                 9    88.16%          27                 0   100.00%         194                 5    97.42%          24                 4    83.33%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4934              1388    71.87%         164                34    79.27%        3542               632    82.16%        1746               955    45.30%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16283      9691             40.48%    178379  98187        44.96%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0ad315

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 27, 2022

Coverage for changed files

Filename                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGContext.h                     28                10    64.29%          21                 9    57.14%          59                17    71.19%           8                 3    62.50%
Functions/FunctionsTiDBConversion.h               794               424    46.60%          76                25    67.11%        1786               602    66.29%         474               317    33.12%
Functions/tests/gtest_tidb_conversion.cpp        3162               766    75.77%          29                 0   100.00%        1266                 0   100.00%         976               500    48.77%
Functions/tests/gtest_timestampdiff.cpp           818               171    79.10%           3                 0   100.00%         168                 0   100.00%         240               123    48.75%
TestUtils/FunctionTestUtils.cpp                    56                 8    85.71%           8                 0   100.00%          69                 8    88.41%          24                 8    66.67%
TestUtils/FunctionTestUtils.h                      76                 9    88.16%          27                 0   100.00%         194                 5    97.42%          24                 4    83.33%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            4934              1388    71.87%         164                34    79.27%        3542               632    82.16%        1746               955    45.30%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16290      9691             40.51%    178356  98151        44.97%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 30cc13c into pingcap:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

@dragonly dragonly Awaiting requested review from dragonly

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unittests for CastRealAsXXX
4 participants
@SeaRise @ti-chi-bot @sre-bot @windtalker